Skip to content

refactor(db): optimize logs for db module#4623

Merged
halibobo1205 merged 1 commit intotronprotocol:release_v4.6.0from
halibobo1205:db_log_opt
Sep 7, 2022
Merged

refactor(db): optimize logs for db module#4623
halibobo1205 merged 1 commit intotronprotocol:release_v4.6.0from
halibobo1205:db_log_opt

Conversation

@halibobo1205
Copy link
Copy Markdown
Collaborator

@halibobo1205 halibobo1205 commented Sep 1, 2022

  1. update log levels
  2. optimize log contents
  3. add some necessary logs

What does this PR do?

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@halibobo1205 halibobo1205 force-pushed the db_log_opt branch 2 times, most recently from ae0f69a to be50912 Compare September 1, 2022 14:45
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release_v4.6.0@626e31e). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release_v4.6.0    #4623   +/-   ##
=================================================
  Coverage                  ?   54.38%           
  Complexity                ?     7983           
=================================================
  Files                     ?      831           
  Lines                     ?    47157           
  Branches                  ?     5108           
=================================================
  Hits                      ?    25645           
  Misses                    ?    19481           
  Partials                  ?     2031           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread chainbase/src/main/java/org/tron/core/ChainBaseManager.java Outdated
Comment thread chainbase/src/main/java/org/tron/core/ChainBaseManager.java Outdated
Comment thread chainbase/src/main/java/org/tron/core/db/BlockIndexStore.java Outdated
Comment thread framework/src/main/java/org/tron/core/db/PendingManager.java Outdated
Comment thread framework/src/main/java/org/tron/core/db/PendingManager.java Outdated
Comment thread framework/src/main/java/org/tron/core/db/PendingManager.java Outdated
Comment thread framework/src/main/java/org/tron/tool/litefullnode/LiteFullNodeTool.java Outdated
Comment thread framework/src/main/java/org/tron/tool/litefullnode/LiteFullNodeTool.java Outdated
@halibobo1205 halibobo1205 force-pushed the db_log_opt branch 3 times, most recently from 1dc8a9a to 2956220 Compare September 6, 2022 04:18
Copy link
Copy Markdown
Contributor

@lurais lurais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments added.

Comment thread framework/src/test/java/org/tron/core/db/ManagerTest.java
Comment thread framework/src/test/java/org/tron/core/db/ManagerTest.java
Comment thread framework/src/test/java/org/tron/core/db/ManagerTest.java
Comment thread framework/src/test/java/org/tron/core/db/ManagerTest.java
  1. update log levels
  2. optimize log contents
  3. add some necessary logs
@halibobo1205 halibobo1205 merged commit 8b6beb8 into tronprotocol:release_v4.6.0 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants