Skip to content

fix(db): fix leveldb manifest rewrite#4655

Merged
halibobo1205 merged 1 commit intotronprotocol:release_v4.6.0from
halibobo1205:feat/add_manifestArchive
Sep 19, 2022
Merged

fix(db): fix leveldb manifest rewrite#4655
halibobo1205 merged 1 commit intotronprotocol:release_v4.6.0from
halibobo1205:feat/add_manifestArchive

Conversation

@halibobo1205
Copy link
Copy Markdown
Collaborator

@halibobo1205 halibobo1205 commented Sep 19, 2022

What does this PR do?

  1. stop generate engine.properties if it is not a db path

Why are these changes required?

Due to #4614, database/checkpoint is added, but it is not a db path.

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

Copy link
Copy Markdown
Contributor

@tomatoishealthy tomatoishealthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. stop generate engine.properties if it is not a db path
@halibobo1205 halibobo1205 force-pushed the feat/add_manifestArchive branch from 13eb9a3 to 6dc92b4 Compare September 19, 2022 10:06
@halibobo1205 halibobo1205 changed the title fix(db): fix leveldb manifest rewrite. fix(db): fix leveldb manifest rewrite Sep 19, 2022
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4655 (6dc92b4) into release_v4.6.0 (e09095c) will increase coverage by 0.03%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release_v4.6.0    #4655      +/-   ##
====================================================
+ Coverage             54.45%   54.48%   +0.03%     
- Complexity             7977     7985       +8     
====================================================
  Files                   831      831              
  Lines                 47120    47120              
  Branches               5103     5103              
====================================================
+ Hits                  25658    25673      +15     
+ Misses                19425    19411      -14     
+ Partials               2037     2036       -1     
Impacted Files Coverage Δ
...tron/common/overlay/discover/node/NodeManager.java 76.97% <0.00%> (-0.66%) ⬇️
.../src/main/java/org/tron/core/ChainBaseManager.java 92.30% <0.00%> (+1.39%) ⬆️
...rc/main/java/org/tron/consensus/dpos/DposTask.java 91.93% <0.00%> (+3.22%) ⬆️
...ain/java/org/tron/common/utils/ForkController.java 79.80% <0.00%> (+5.76%) ⬆️
...rc/main/java/org/tron/core/db/BlockIndexStore.java 58.33% <0.00%> (+8.33%) ⬆️
.../java/org/tron/core/consensus/BlockHandleImpl.java 80.00% <0.00%> (+15.00%) ⬆️
...org/tron/core/exception/ItemNotFoundException.java 66.66% <0.00%> (+33.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@halibobo1205 halibobo1205 merged commit a34d428 into tronprotocol:release_v4.6.0 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants