Skip to content

feat(CONTRIBUTING.md): update CONTRIBUTING.md #4789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forfreeday merged 1 commit into from
Nov 14, 2022
Merged

feat(CONTRIBUTING.md): update CONTRIBUTING.md #4789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,12 @@ If you want to contribute codes to java-tron, please follow the following steps:

Submit a pull request (PR) from your repository to `tronprotocol/java-tron`.
Please be sure to click on the link in the red box shown below. Select the base branch for tronprotocol and the compare branch for your personal fork repository.
![](https://codimd.s3.shivering-isles.com/demo/uploads/e24435ab42e4287d9369a2136.png)
![image](https://raw.githubusercontent.com/tronprotocol/documentation-en/master/images/javatron_pr.png)



## Code Review Guidelines
The only way to get code into java-tron is to send a pull request. Those pull requests need to be reviewed by someone. there a guide that explains our expectations around PRs for both authors and reviewers.
The only way to get code into java-tron is to send a pull request. Those pull requests need to be reviewed by someone. The following guide explains our expectations around PRs for both authors and reviewers.

### Terminology
- The author of a pull request is the entity who wrote the diff and submitted it to GitHub.
Expand Down
4 changes: 2 additions & 2 deletions framework/src/main/java/org/tron/core/Wallet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,7 @@ public long getTransactionCountByBlockNum(long blockNum) {
Block block = chainBaseManager.getBlockByNum(blockNum).getInstance();
count = block.getTransactionsCount();
} catch (StoreException e) {
logger.error(e.getMessage());
logger.warn(e.getMessage());
}

return count;
Expand Down Expand Up @@ -1414,7 +1414,7 @@ public Block getBlockById(ByteString blockId) {
try {
block = chainBaseManager.getBlockStore().get(blockId.toByteArray()).getInstance();
} catch (StoreException e) {
logger.error(e.getMessage());
logger.warn(e.getMessage());
}
return block;
}
Expand Down