Skip to content

fix(block): fix block size estimation during block production#4893

Merged
halibobo1205 merged 1 commit intorelease_v4.7.0from
fix/compute_block_size
Jan 4, 2023
Merged

fix(block): fix block size estimation during block production#4893
halibobo1205 merged 1 commit intorelease_v4.7.0from
fix/compute_block_size

Conversation

@halibobo1205
Copy link
Copy Markdown
Collaborator

@halibobo1205 halibobo1205 commented Jan 4, 2023

What does this PR do?
Fix block size estimation during block production, use CodedOutputStream.computeMessageSize(final int fieldNumber, final MessageLite value) for WIRETYPE_LENGTH_DELIMITED message, TLV = type + length+ value.
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@halibobo1205 halibobo1205 force-pushed the fix/compute_block_size branch from e20ee09 to df74a86 Compare January 4, 2023 06:36
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #4893 (3eaa998) into release_v4.7.0 (f17cab4) will increase coverage by 0.16%.
The diff coverage is 88.88%.

@@                 Coverage Diff                  @@
##             release_v4.7.0    #4893      +/-   ##
====================================================
+ Coverage             53.51%   53.67%   +0.16%     
- Complexity             8146     8172      +26     
====================================================
  Files                   840      840              
  Lines                 49597    49601       +4     
  Branches               5429     5429              
====================================================
+ Hits                  26542    26625      +83     
+ Misses                20979    20910      -69     
+ Partials               2076     2066      -10     
Impacted Files Coverage Δ
...mework/src/main/java/org/tron/core/db/Manager.java 53.68% <85.71%> (+0.74%) ⬆️
.../main/java/org/tron/core/capsule/BlockCapsule.java 82.01% <100.00%> (+0.09%) ⬆️
...java/org/tron/core/capsule/TransactionCapsule.java 50.58% <100.00%> (+0.11%) ⬆️
...rc/main/java/org/tron/core/vm/program/Program.java 67.42% <0.00%> (+0.08%) ⬆️
...va/org/tron/core/store/DynamicPropertiesStore.java 97.47% <0.00%> (+0.17%) ⬆️
...c/main/java/org/tron/core/actuator/VMActuator.java 65.01% <0.00%> (+0.24%) ⬆️
...n/java/org/tron/core/db2/core/SnapshotManager.java 73.50% <0.00%> (+0.56%) ⬆️
...s/interfaceOnSolidity/RpcApiServiceOnSolidity.java 17.19% <0.00%> (+0.90%) ⬆️
...rc/main/java/org/tron/core/db2/core/Chainbase.java 68.33% <0.00%> (+1.11%) ⬆️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@halibobo1205 halibobo1205 force-pushed the fix/compute_block_size branch from df74a86 to 3eaa998 Compare January 4, 2023 08:07
@halibobo1205 halibobo1205 merged commit 8f57f4a into release_v4.7.0 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants