fix(block): fix block size estimation during block production#4893
Merged
halibobo1205 merged 1 commit intorelease_v4.7.0from Jan 4, 2023
Merged
fix(block): fix block size estimation during block production#4893halibobo1205 merged 1 commit intorelease_v4.7.0from
halibobo1205 merged 1 commit intorelease_v4.7.0from
Conversation
e20ee09 to
df74a86
Compare
zhang0125
approved these changes
Jan 4, 2023
Codecov Report
@@ Coverage Diff @@
## release_v4.7.0 #4893 +/- ##
====================================================
+ Coverage 53.51% 53.67% +0.16%
- Complexity 8146 8172 +26
====================================================
Files 840 840
Lines 49597 49601 +4
Branches 5429 5429
====================================================
+ Hits 26542 26625 +83
+ Misses 20979 20910 -69
+ Partials 2076 2066 -10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tomatoishealthy
approved these changes
Jan 4, 2023
df74a86 to
3eaa998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix block size estimation during block production, use
CodedOutputStream.computeMessageSize(final int fieldNumber, final MessageLite value)forWIRETYPE_LENGTH_DELIMITEDmessage, TLV = type + length+ value.Why are these changes required?
This PR has been tested by:
Follow up
Extra details