Skip to content

feat(config): optimize rate.limiter configuration parsing#5206

Merged
xxo1shine merged 1 commit intotronprotocol:release_v4.7.2from
xxo1shine:optimize_config_parse
May 8, 2023
Merged

feat(config): optimize rate.limiter configuration parsing#5206
xxo1shine merged 1 commit intotronprotocol:release_v4.7.2from
xxo1shine:optimize_config_parse

Conversation

@xxo1shine
Copy link
Copy Markdown
Collaborator

@xxo1shine xxo1shine commented May 8, 2023

What does this PR do?
Optimize rate.limiter configuration parsing.

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 8, 2023

Codecov Report

Merging #5206 (1cd7c3e) into release_v4.7.2 (3fa8c4f) will increase coverage by 0.26%.
The diff coverage is 72.22%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                 Coverage Diff                  @@
##             release_v4.7.2    #5206      +/-   ##
====================================================
+ Coverage             59.27%   59.53%   +0.26%     
- Complexity             8821     8860      +39     
====================================================
  Files                   836      836              
  Lines                 49628    49637       +9     
  Branches               5524     5526       +2     
====================================================
+ Hits                  29417    29552     +135     
+ Misses                17881    17752     -129     
- Partials               2330     2333       +3     
Impacted Files Coverage Δ
common/src/main/java/org/tron/core/Constant.java 50.00% <ø> (ø)
...n/core/net/messagehandler/InventoryMsgHandler.java 40.00% <0.00%> (+7.64%) ⬆️
...ava/org/tron/common/parameter/CommonParameter.java 57.26% <50.00%> (+0.24%) ⬆️
...in/java/org/tron/core/net/P2pEventHandlerImpl.java 38.52% <83.33%> (+29.43%) ⬆️
.../src/main/java/org/tron/core/config/args/Args.java 60.03% <93.75%> (+0.22%) ⬆️

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxo1shine xxo1shine merged commit 17f9304 into tronprotocol:release_v4.7.2 May 8, 2023
@xxo1shine xxo1shine deleted the optimize_config_parse branch May 24, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants