feat(log): optimize checkpoint log print#5383
feat(log): optimize checkpoint log print#5383halibobo1205 merged 1 commit intotronprotocol:developfrom
Conversation
| if (cpList != null && cpList.size() != 0) { | ||
| logger.error("checkpoint check failed, can't convert checkpoint from v2 to v1"); | ||
| logger.error("checkpoint check failed, can't convert checkpoint from v2 to v1," + | ||
| " please set checkpoint.version = 2"); |
There was a problem hiding this comment.
where can be found for checkpoint.version ?
| if (cpList != null && cpList.size() != 0) { | ||
| logger.error("checkpoint check failed, can't convert checkpoint from v2 to v1"); | ||
| logger.error("checkpoint check failed, can't convert checkpoint from v2 to v1," + | ||
| " please set checkpoint.version = 2 in your config file and restart it."); |
There was a problem hiding this comment.
how and where for config if checkpoint.version is missed ?
There was a problem hiding this comment.
Maybe a full config path is better: storage.checkpoint.version
There was a problem hiding this comment.
how and where for config if
checkpoint.versionis missed ?
The full path is needed.
There was a problem hiding this comment.
change and restart it to and restart or and restart the node?
There was a problem hiding this comment.
Change to ''and restart the node'' seems to be more precise.
|
You can merge the commits by using |
lurais
force-pushed
the
feature/optimize_checkpoint_log
branch
from
47ff6f6 to
71426df
Compare
done. @guoquanwu |
| List<String> cpList = getCheckpointList(); | ||
| if (cpList != null && cpList.size() != 0) { | ||
| logger.error("checkpoint check failed, can't convert checkpoint from v2 to v1"); | ||
| logger.error("checkpoint check failed, can't convert checkpoint from v2 to v1," + |
There was a problem hiding this comment.
may be not converted by user, the database can be downloaded from somewhere
There was a problem hiding this comment.
@halibobo1205 The reason should be the database not match to the config file, so just print " the checkpoint version of database not match your config file ,please ..." ?
lurais
force-pushed
the
feature/optimize_checkpoint_log
branch
from
71426df to
f993740
Compare
|
@lurais Please fix CI test. |
|
3 participants
What does this PR do?
Add log to suggest to change the checkpoint config when it try to convert from v2 to v1 while the error info is printed.
Why are these changes required?
To improve user friendliness.