feat(zksnark): delete sapling tmp file on exit#5467
Merged
halibobo1205 merged 1 commit intotronprotocol:developfrom Sep 5, 2023
Merged
feat(zksnark): delete sapling tmp file on exit#5467halibobo1205 merged 1 commit intotronprotocol:developfrom
halibobo1205 merged 1 commit intotronprotocol:developfrom
Conversation
317787106
approved these changes
Sep 4, 2023
| } | ||
| if (fileOut.exists()) { | ||
| fileOut.deleteOnExit(); | ||
| } |
Collaborator
There was a problem hiding this comment.
Will it delete twice ? It is possbile to delete these two files manually when close ?
Collaborator
Author
There was a problem hiding this comment.
Will it delete twice ?
No, Even that's okay.
It is possbile to delete these two files manually when close ?
jni file, it's safer to delete it at the end by DeleteOnExitHook.
tomatoishealthy
approved these changes
Sep 4, 2023
halibobo1205
force-pushed
the
feat/zksnark
branch
from
a3f2bfe to
b07add0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #5465