-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(doc): update x86 java start params #6478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(doc): update x86 java start params #6478
Conversation
…/java-tron into release_v4.8.1_fix_jvm # Conflicts: # README.md
| ### ARM64 (JDK 17) | ||
| ```bash | ||
| $ nohup java -Xms9G -Xmx9G -XX:+UseZGC \ | ||
| $ nohup java -Xmx9G -XX:+UseZGC \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why delete
-Xms9Gfor ZGC just for fullnode? - If so, the same changes are required for SR and
start.sh.sample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because in normal case FullNode don't need minimum 9G,as JDK 17 use RocksDB, which will take more space. It is not directly related with ZGC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SR don't need change, as the minimum requirement for SR machine is 64G, so it does not matter. This remove Xms9G is used more for 16G machines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I changed start.sh.sample
2be3670 to
86ac0a7
Compare
Squashed commits: [fe4369f510] revert (+1 squashed commit) Squashed commits: [1925a2d1f1] revert (+1 squashed commit) Squashed commits: [336092cd1a] feat(dependencies): bump libp2p from 2.2.6 to 2.2.7 (tronprotocol#6481) * update libp2p from 2.2.6 to 2.2.7 * add pom file (+4 squashed commits) Squashed commits: [d0bdaf0] revert changes [6b14bdb] JDK 8 [d279184] modify start.sh.simple [e24693a] update (+1 squashed commit) Squashed commits: [b54aed3] revert commitee config for proposalExpireTime (+1 squashed commit) Squashed commits: [e132811] update config for proposalExpireTime
86ac0a7 to
c90a254
Compare
What does this PR do?
Why are these changes required?
-Xmx 12Gis safe for a simple FullNode even when blocks fail to solidify promptly—even with a maximum wait of one maintenance window.-Xmxin JDK 17 because in normal case FullNode don't need minimum 9G,as JDK 17 use RocksDB, which will take more space.This PR has been tested by:
Follow up
Extra details