Skip to content

Conversation

@Sunny6889
Copy link

@Sunny6889 Sunny6889 commented Nov 10, 2025

What does this PR do?

  • Provide more detailed Storage and Network specifications, and adjust the formatting.
  • Update the x86_64 FullNode running JVM Parameters

Why are these changes required?

  • From our tests, -Xmx 12G is safe for a simple FullNode even when blocks fail to solidify promptly—even with a maximum wait of one maintenance window.
  • Remove -Xmx in JDK 17 because in normal case FullNode don't need minimum 9G,as JDK 17 use RocksDB, which will take more space.

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

### ARM64 (JDK 17)
```bash
$ nohup java -Xms9G -Xmx9G -XX:+UseZGC \
$ nohup java -Xmx9G -XX:+UseZGC \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why delete -Xms9G for ZGC just for fullnode?
  2. If so, the same changes are required for SR and start.sh.sample

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in normal case FullNode don't need minimum 9G,as JDK 17 use RocksDB, which will take more space. It is not directly related with ZGC.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SR don't need change, as the minimum requirement for SR machine is 64G, so it does not matter. This remove Xms9G is used more for 16G machines.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I changed start.sh.sample

@Sunny6889 Sunny6889 force-pushed the release_v4.8.1_fix_jvm branch 2 times, most recently from 2be3670 to 86ac0a7 Compare November 20, 2025 06:43
Squashed commits:
[fe4369f510] revert (+1 squashed commit)
Squashed commits:
[1925a2d1f1] revert (+1 squashed commit)
Squashed commits:
[336092cd1a] feat(dependencies): bump libp2p from 2.2.6 to 2.2.7 (tronprotocol#6481)

* update libp2p from 2.2.6 to 2.2.7
* add pom file (+4 squashed commits)
Squashed commits:
[d0bdaf0] revert changes
[6b14bdb] JDK 8
[d279184] modify start.sh.simple
[e24693a] update (+1 squashed commit)
Squashed commits:
[b54aed3] revert commitee config for proposalExpireTime (+1 squashed commit)
Squashed commits:
[e132811] update config for proposalExpireTime
@Sunny6889 Sunny6889 force-pushed the release_v4.8.1_fix_jvm branch from 86ac0a7 to c90a254 Compare November 20, 2025 06:47
@kuny0707 kuny0707 merged commit 1b637fd into tronprotocol:release_v4.8.1 Nov 25, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in java-tron Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants