feat(net): normalize inbound messages#6797
Merged
lvs0075 merged 2 commits intoMay 25, 2026
Merged
Conversation
656cb38 to
cdcceba
Compare
317787106
reviewed
May 25, 2026
cdcceba to
1dd07e7
Compare
317787106
reviewed
May 25, 2026
xxo1shine
approved these changes
May 25, 2026
317787106
approved these changes
May 25, 2026
lvs0075
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
sanitize()toBlockCapsuleandTransactionCapsulethat normalizes the protobuf representation by stripping outer unknown fields, leaving all consensus-hashed and signed regions byte-identical.Invocation:
BlockMsgHandler.processMessagecallsblockMessage.sanitize()after the existing size/time checks and before sync/adv dispatch.BlockMessage.sanitize()updates both the capsule and the message's wiredatafield (if it contains unknown fields).Manager.processTransactioncallstrxCap.sanitize()after signature validation, only for mempool transactions (!trxCap.isInBlock()).Wallet.broadcastTransactionconstructs the outboundTransactionMessageafterpushTransactionso it reflects the post-sanitize state.Each
sanitize()short-circuits when there are no unknown fields, so the common path is allocation-free.Compatibility