-
Notifications
You must be signed in to change notification settings - Fork 290
add tip-767 #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tip-767 #806
Conversation
tip-767.md
Outdated
|
|
||
| - After exceeding the on-chain `proposalExpireTime` and during the nearest maintenance period, the proposal automatically expires (even if approving is incomplete). | ||
|
|
||
| **Block Validation**: Nodes must reject transactions that rely on expired proposals (based on on-chain parameters). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence reads a bit confusing—what does it mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Federico2014
When a proposal exceeds the voting window specified on the chain, it officially expires. Any transaction that attempts to execute the content of this "expired proposal" must be rejected and verified as illegal by all nodes when packaged into the block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term expired proposal is ambiguous. At first, I thought it meant that a proposal becomes expired when its voting window ends. But what you’re saying here is that once a new proposal takes effect, the old one becomes expired?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposal transaction initiated has a voting window. If the proposal transaction expires, it will be rejected when approving the proposal transaction. It's that simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just means the related ProposalApproval transaction will be rejected if the proposal exceeds the voting window specified on the chain. This should be clarified.
7b08cca to
6b421e4
Compare
No description provided.