fix: add isAvailable check in getInvoker to prevent idle eviction race condition#140
Merged
wardseptember merged 1 commit intoMay 7, 2026
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
61e84d6 to
920dd3a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
=====================================================
- Coverage 85.86041% 85.84151% -0.01891%
+ Complexity 4325 4321 -4
=====================================================
Files 436 436
Lines 14371 14373 +2
Branches 1286 1287 +1
=====================================================
- Hits 12339 12338 -1
- Misses 2032 2035 +3
🚀 New features to boost your workflow:
|
b632803 to
2450a32
Compare
2450a32 to
f4b3873
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add an
isAvailable()check on the fast path ofDefClusterInvoker.getInvoker().Why
When the idle scanner (
scanUnusedClient) closes an RpcClient, there is a time window betweenclient.close()and thecloseFuturecallback removing the invoker frominvokerCache. During this window, business threads can obtain a stale invoker whose underlying transport is already shut down, resulting inClient stoperrors.How
If the cached invoker's RpcClient is no longer available (STOPPING/STOPPED state), fall through to
createInvoker()which rebuilds a new RpcClient under proper synchronization.