fix: grab call expression deeper than 2 calls#6489
fix: grab call expression deeper than 2 calls#6489juliusmarminge merged 12 commits intotrpc:query-optoins-codemodfrom
Conversation
moves up the tree to find the actuall call expression and use the correct replace helper
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@barelyhuman is attempting to deploy a commit to the trpc Team on Vercel. A member of the Team first needs to authorize it. |
@trpc/client
@trpc/next
@trpc/server
@trpc/tanstack-react-query
@trpc/react-query
@trpc/upgrade
commit: |
juliusmarminge
left a comment
There was a problem hiding this comment.
not able to test now, but does this make it pass on the next-prisma-starter example?? π
That's the only one I tested it on, I'm going to mark it as draft so I can test the other examples, will do it post day job today so give me a bit. I'm guessing there's a few similar issues so should be ablel to wrap it up in one PR, if they are different however, I'll raise a different PR |
|
@juliusmarminge Before I add more utils for the transformer, any standard / doc on the folder structure or do I just make a |
do what you feel is right! |
|
Confirmed, working with all examples, no crashes or warnings If there's any additional behavior that needs to be added, do let me know |
juliusmarminge
left a comment
There was a problem hiding this comment.
Awesome! Thank you!
You wanna keep working on the provider transform bugs I mentioned here? #6262 (comment)
Sure, I don't mind. query though, wouldn't it be nice to have it as a separate PR ? |
Yea I'll merge this one and you can open a new one :) |
Re this: The Most other examples uses |
|
This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you. |
moves up the tree to find the actuall call expression and use the correct replace helper
Closes #
π― Changes
Backward compatible change to make sure the correct call expression is picked in a nested expression.
Old code picked
utils.x.helper()but wouldn't do it forutils.x.y.z.helper(), this fixes thatβ Checklist