#129 io: skip 046-write_wakes_on_peer_reset on Windows#135
Merged
EdmondDantes merged 1 commit intoMay 22, 2026
Conversation
The test and the #129 item 1 fix target the POSIX poll/POLLERR peer-reset path. On Windows the writer does not hang, but Winsock surfaces WSAECONNRESET to a write on a different schedule, so the "second fwrite fails" assertion does not hold. Pre-existing failure, not a regression. Skipped on Windows; the open question of whether Windows reliably signals the reset is tracked in #134.
EdmondDantes
deleted the
129-io-chaos-follow-up-write-path-toxics-real-rst-forked-peer-failure-freeze
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/stream/046-write_wakes_on_peer_reset.phpt— the #129 item 1regression test — fails on Windows. Pre-existing (it failed in #131 too,
masked by the
tests/io/083failure that #133 has now fixed).The test and the item 1 fix target the POSIX
poll/POLLERRpeer-resetpath. On Windows the writer does not hang (the catastrophic symptom
item 1 fixed does not reproduce), but Winsock surfaces
WSAECONNRESETtoa write on a different schedule, so the "second fwrite fails" assertion
does not hold.
Skipped on Windows via
--SKIPIF--; the POSIX path stays covered. WhetherWindows reliably signals a peer reset to a blocked writer is tracked in
#134.