Fiber support #71
Merged
Fiber support #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 016: Nested fibers in separate coroutines with symmetric switching - 017: Multiple suspend/resume in different coroutines - 018: GC with circular references between fibers and coroutines Tests verify that fibers in different coroutines are independent and properly delegate GC to coroutine handlers.
…& ZEND_ASYNC_ACTIVE_EVENT_COUNT > 0;
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive fiber support to the async coroutine system, enabling fibers to work seamlessly with the existing async scheduler. The implementation includes deadlock detection for yielded fiber coroutines, scope validation, and updates to the libuv reactor logic.
Key Changes:
- Added deadlock resolution logic for fiber coroutines in YIELD state
- Implemented scope validation check before coroutine enqueue
- Modified libuv reactor return logic to handle fiber scenarios
Reviewed changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| scheduler.c | Added fiber-aware deadlock detection and scope validation for coroutine enqueuing |
| libuv_reactor.c | Modified reactor execute return logic for fiber integration |
| coroutine.h | Added zend_fibers.h header include |
| tests/fiber/*.phpt | 28 comprehensive test files covering fiber basics, edge cases, and cancellation |
| tests/edge_cases/*.phpt | 3 test files for fiber-spawn interaction scenarios and GC behavior |
| tests/stream/032-stream_select_null_timeout.phpt | Test for stream_select with null timeout in fiber context |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ccurs in the main coroutine while the GC is running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.