+ Added customizable scheduler heartbeat handler mechanism with `zend… #77
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_async_set_heartbeat_handler()` API
There was a problem hiding this comment.
Pull request overview
This PR aims to add a customizable scheduler heartbeat handler mechanism to the TrueAsync extension, allowing developers to register custom callbacks that execute during scheduler operations. However, the implementation is incomplete and contains several critical issues that prevent compilation.
- The heartbeat handler mechanism is partially implemented in the scheduler but lacks essential infrastructure components
- Test file changes appear unrelated to the heartbeat handler feature
- The documented API function is not implemented
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| scheduler.c | Introduces heartbeat handler invocation points in fiber_entry and scheduler_next_tick, relocating ZEND_ASYNC_SCHEDULER_HEARTBEAT macro usage, but references undefined types and globals |
| CHANGELOG.md | Documents the new heartbeat handler feature with the zend_async_set_heartbeat_handler() API |
| tests/curl/005-error_handling.phpt | Updates await_all usage to capture both results and exceptions via array destructuring, and adjusts expected test output order - changes appear unrelated to heartbeat handler feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added customizable scheduler heartbeat handler mechanism with
zend_async_set_heartbeat_handler()API