http1: scan request-target in on_url (single pass, follow-up to #57)#58
Merged
Merged
Conversation
…ass) Follow-up to #57: move the '#'/'\' request-target rejection from on_headers_complete (a second full scan of the assembled URI) into on_url, where llhttp already passes over those bytes as it accumulates the target. Single pass, rejects earlier (mid-request-line, before headers), and mirrors the existing URI-size check in the same callback. Both are single byte values so a chunk boundary can't split them. Behaviour identical — h1/021 + full tests/phpt 203/203.
Contributor
CoverageTotal lines: 80.70% → 80.69% (-0.00 pp)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor of the #57 fragment/backslash check — no behaviour change.
Moves the
'#'/'\'request-target rejection fromon_headers_complete(which re-scanned the fully-assembled URI — a second pass) intoon_url, where llhttp already iterates those bytes while accumulating the target. Result: single pass, rejects earlier (mid request-line, before headers are parsed), and sits next to the existing URI-size check in the same callback.Safe across chunk boundaries —
#/\are single bytes, can't be split.h1/021+ fulltests/phpt203/203.