chore(fixtures): remove legacy m1-m4 xlsx fixtures and align lab with source-first layout#516
Merged
Merged
Conversation
… source-first layout - Delete m1/, m2/, m3/, m4/ directories: the one-shot xlsx→TSV migration has already run and no conformance test reads these files - Delete migrate_fixtures.rs: marked "run once, then delete this file" - Move lab/financial.tsv → lab/google_sheets/financial.tsv to mirror the source-first directory convention used by canonical fixtures - Update lab_conformance to scan lab/ recursively so it picks up cases under any source subdirectory (google_sheets/, excel/, etc.) - Update lab/README.md to document the source-first subdirectory layout Closes #515 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Test Coverage by Category
Oracle: Google Sheets · ✓ = 100% passing · ⚠ = known deviation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
m1/,m2/,m3/,m4/directories — the one-shot xlsx→TSV migration has already run; no conformance test reads these filesmigrate_fixtures.rs— the file itself said "run once, then delete this file"lab/financial.tsv→lab/google_sheets/financial.tsvto mirror the source-first directory convention used by canonical fixtureslab_conformanceto scanlab/recursively so it picks up cases under any source subdirectory (google_sheets/,excel/, etc.)lab/README.mdto document the source-first subdirectory layoutCloses #515
Test plan
cargo nextest run -p truecalc-core --test conformance— all 19 tests passlab_conformancefinds and runslab/google_sheets/financial.tsvmigrate_fixtures.rsremain🤖 Generated with Claude Code