Skip to content

feat(website): add documentation website#16

Merged
richbachman merged 3 commits intomainfrom
feat/website
Dec 1, 2021
Merged

feat(website): add documentation website#16
richbachman merged 3 commits intomainfrom
feat/website

Conversation

@richbachman
Copy link
Contributor

@richbachman richbachman commented Nov 29, 2021

Description of the change

Sets up the initial doc site structure and a couple of test pages. Once this is merged to main, I'll setup the Vercel deploy.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link
Contributor

@jnlsn jnlsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think you might need to delete .pnp.cjs so git will stop tracking it.

@richbachman
Copy link
Contributor Author

richbachman commented Nov 30, 2021

Looks good! I think you might need to delete .pnp.cjs so git will stop tracking it.

@jayarnielsen I thought we wanted that in there:
https://yarnpkg.com/features/pnp

The generated .pnp.cjs file can be committed to your repository as part of the Zero-Installs effort, removing the need to run yarn install in the first place.

@jnlsn
Copy link
Contributor

jnlsn commented Dec 1, 2021

Oh okay, in that case I think we are git ignoring too many files: https://yarnpkg.com/getting-started/qa/#which-files-should-be-gitignored

@richbachman richbachman merged commit eab8cb7 into main Dec 1, 2021
@richbachman richbachman deleted the feat/website branch December 1, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants