Skip to content

feat(status-icon): add status icon component and stories#30

Merged
richbachman merged 2 commits intomainfrom
feat/status-icon
Jan 4, 2022
Merged

feat(status-icon): add status icon component and stories#30
richbachman merged 2 commits intomainfrom
feat/status-icon

Conversation

@richbachman
Copy link
Contributor

@richbachman richbachman commented Dec 30, 2021 •
edited
Loading

Description of the change

  • Adds status icon component, stories, and tests
  • Adds xxsmall icon size. Adjusted xsmall icons size to 12px

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@richbachman richbachman marked this pull request as ready for review January 3, 2022 22:31
@trueplan-automaton trueplan-automaton requested review from a team and markrebec and removed request for a team January 3, 2022 22:31
@richbachman
Copy link
Contributor Author

richbachman commented Jan 3, 2022 •
edited
Loading

@jayarnielsen @markrebec getting some design feedback on this one. Not quite ready for review yet.

@richbachman
Copy link
Contributor Author

richbachman commented Jan 3, 2022

@jayarnielsen @markrebec getting some design feedback on this one. Not quite ready for review yet.

Code is ready now. May still have some design decision changes.

jnlsn
jnlsn approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@jnlsn jnlsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@richbachman richbachman merged commit 7e8cde3 into main Jan 4, 2022
@richbachman richbachman deleted the feat/status-icon branch January 4, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markrebec markrebec Awaiting requested review from markrebec markrebec was automatically assigned from trueplan/front-end-engineers

1 more reviewer

@jnlsn jnlsn jnlsn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@richbachman @jnlsn