refactor: sync repo with kwil v0.7#117
Conversation
6be6013 to
ce92cb4
Compare
ce92cb4 to
8e42c80
Compare
|
@MicBun please resolve conflicts |
44caa28 to
b012f45
Compare
|
Hey @MicBun, so the idea is merging all the problems as PRs to this branch and finally merge it, right? If you want some help on some of these, maybe we can create sub-issues where we can control who's taking what. |
@outerlook
Sure, you may continue to do so, please keep in mind some functions is missing in the new kwil 0.7 like |
|
@MicBun @outerlook let's follow Michael's suggestion 👍 |
…/upgrade-zero-seven # Conflicts: # .github/workflows/ci.yaml # scripts/ci-tests.sh # scripts/use_base_schema.sh # truflation/base_schema/base_schema.kf # truflation/develop_experiments/develop_scripts.md # truflation/docker/tsn.dockerfile # truflation/infra/cdk_main.go
|
For now, I pushed directly some commits to eliminate upfront conflicts, and now, I'll open PRs to it |
|
Hi @zolotokrylin, the merge is ready now, you might want to have a final look. |
|
Well done guys! Great work! |
That would be good. It's necessary for the new deployment action to work correctly. Note that |
|
Hey @MicBun and @outerlook are we waiting here for @zolotokrylin to setup the wallets and private keys? |
@markholdex Yes, that would be good. otherwise, it is only going to be merged with main, while staging will be crashed due to missing private keys. |
@outerlook does it mean that our "node operator" users will have access to PRIVAT_KEY? Or will they have their own private keys? How will it work when we need to deploy other nodes run by third parties? |
If third parties have their schemas, they should have their own It will be accessible because it is currently available as a plaintext file at our EC2 instance. In the future, for further protection, we could also encrypt the files, but that could happen later, right?
For now, of course, you can set a public value for these and share it with us (e.g.: |
* deployments/infra/cdk_main.go: make kwil gateway binary available in ec2 instance This PR extracts logic for creating ec2 role into its own function. Also it adds a boot up script to ec2 instance to fetch from s3 the kwil gateway binary. Resolves #109. * apply pr comments keep binary out of tmp folder * address pr comments change place of newName variable * address pr comment move binary to /usr/local/bin * address pr comments rewrite kwilGatewayBinaryScript
|
@outerlook thank you!
|
Not as it is now :( However, the possible next iteration, with a metadata table, already foresees a dynamic behavior here |
Description
Complete Refactor to sync with Kwil v0.7
Related Issue
#114
Motivation and Context
One step closer for this goal: #114
How Has This Been Tested?
mainkwil-cli utils pingand some actionsTypes of changes
Checklist:
Checklist Explanation:
How to Review this PR:
Additional Information:
Managed to run
kwild --autogenand call get index and value with the default date, need to take a look in separate PR, if this architecture is acceptable please make future PR to this branch instead of main, after we finalize everything then we may merge to main.