chore: update kwil-db depedency for automatic recover#1308
Conversation
Time Submission Status
You can submit time with the command. Example: See available commands to help comply with our Guidelines. |
📝 WalkthroughWalkthroughUpdates include a kwil-db dependency bump in Changes
Sequence Diagram(s)(Skipped — changes are test/data updates and do not introduce a new multi-component runtime control flow requiring visualization.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@go.mod`:
- Around line 22-23: Update the PR title to fix typos ("udpate" → "update",
"depedency" → "dependency") and verify the kwil-db upgrade is safe: compare API
surface between commits 4fab48fcfa11 and 1a21f34293d9 for modules
github.com/trufnetwork/kwil-db and github.com/trufnetwork/kwil-db/core (e.g.,
generate diff of exported symbols or run `git
diff`/`godef`/`golang.org/x/tools/cmd/godoc` between those commits), run full
test and vet of the repo with the new versions (go test ./... and go vet) to
ensure automatic recovery integration is covered, and add/verify
unit/integration tests that exercise the resistantRetry/automatic recovery
behavior before merging.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@tests/streams/other/other_test.go`:
- Around line 185-207: The test registers owner1 but never registers owner2, so
the failure from setup.UntypedCreateStream may be due to missing registration
rather than stream-ID uniqueness; before calling setup.UntypedCreateStream in
the NonDuplicateStreamID_DifferentOwner test, call setup.CreateDataProvider(ctx,
platform, owner2) and require.NoError on it (using the same pattern as owner1)
so the test deterministically exercises cross-owner uniqueness; alternatively,
if global uniqueness is intended, update the test comment to reflect that and
assert the appropriate error instead.
resolves: https://github.com/truflation/website/issues/3205
Summary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.