fix: unknown sender and tx ID on explorer transactions#1372
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR routes fee balance checks/transfers to the hoodi_tt (and sepolia_bridge where applicable), removes runtime SQL namespace substitution in the migration loader, updates the prod-migration generator alias mapping, and consolidates transaction-history into a ledger-backed get_last_transactions action. ChangesFee Collection Bridge Migration to hoodi_tt
Transaction History View Consolidation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bug Report Checklist
If this commit or author is incorrect, reply in this PR with:
Use git blame to identify the right commit and author before posting. See available commands to help comply with our Guidelines. |
Time Submission Status
You can submit time with the command. Example: See available commands to help comply with our Guidelines. |
|
@holdex pr submit-time 2h |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/migrations/010-get-latest-write-activity.sql`:
- Around line 9-13: Update the migration docstring to stop referencing
non-existent cleanup scripts: either add the missing maintenance DROP scripts
for get_last_transactions_v1 and get_last_transactions_v2 to the repo, or change
the comment in internal/migrations/010-get-latest-write-activity.sql to explain
the actual cleanup path (e.g., that retired variants are dropped elsewhere or
will be removed manually), and remove the `maintenance/` reference; mention the
specific retired functions get_last_transactions_v1 and get_last_transactions_v2
and keep the note about preserving `$data_provider` for SDK backward
compatibility so operators know what to do after migration.
In `@internal/migrations/migration.go`:
- Line 99: Embedded SQL content appended via statements = append(statements,
string(content)) still contains legacy "ethereum_bridge" namespace references
which break literal file migrations; update the SQL files themselves so the
embedded content is correct: replace all "ethereum_bridge" occurrences in
internal/migrations/erc20-bridge/001-actions.sql (lines noted),
internal/migrations/erc20-bridge/002-public-transfer-actions.sql, and
internal/migrations/032-order-book-actions.sql with the appropriate environment
namespaces (dev: hoodi_tt or hoodi_tt2 or sepolia_bridge; prod: eth_truf or
eth_usdc), or parameterize the SQL before embedding if you need
environment-specific values, and re-run tests to ensure scripts/migrate.sh
applies the corrected SQL without runtime substitution.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d2661737-4beb-4f02-a321-849f1a66a325
📒 Files selected for processing (11)
internal/migrations/001-common-actions.sqlinternal/migrations/003-primitive-insertion.sqlinternal/migrations/004-composed-taxonomy.sqlinternal/migrations/010-get-latest-write-activity.sqlinternal/migrations/024-attestation-actions.sqlinternal/migrations/migration.goscripts/generate_prod_migrations.pytests/streams/order_book/settlement_payout_test.gotests/streams/transaction_events_ledger_test.gotests/streams/utils/feefund/feefund_kwiltest.gotests/streams/withdrawal_fee_test.go
resolves: https://github.com/truflation/website/issues/3873
Summary by CodeRabbit
API Changes
Infrastructure