feat: add test collection short ID to upload metadata#1077
Merged
trunk-io[bot] merged 3 commits intomainfrom Apr 28, 2026
Merged
feat: add test collection short ID to upload metadata#1077trunk-io[bot] merged 3 commits intomainfrom
trunk-io[bot] merged 3 commits intomainfrom
Conversation
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
+ Coverage 81.73% 82.00% +0.26%
==========================================
Files 69 69
Lines 14905 14907 +2
==========================================
+ Hits 12183 12224 +41
+ Misses 2722 2683 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dfrankland
requested review from
TylerJang27,
acatxnamedvirtue,
max-trunk and
mb1206
pat-trunk-io
approved these changes
Apr 28, 2026
| await expect( | ||
| async () => await parse_meta_from_tarball(readableStream), | ||
| ).rejects.toThrow("missing field `version`"); | ||
| await expect(parse_meta_from_tarball(readableStream)).rejects.toThrowError( |
Member
Author
There was a problem hiding this comment.
it is async, we just didn't need a wrapping async fn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add an optional test collection short ID to upload metadata and expose it through
trunk-analytics-cli upload.Details
This threads
test_collection_short_idthrough bundle metadata construction, adds a CLI flag and env var, and updates the manual bundle fixture so downstream consumers can start inspecting bundle uploads for a specified collection.Testing
cargo test -p trunk-analytics-cli --no-runFollow-up Work