(CI): Use fewer release test variants#1130
Merged
Merged
Conversation
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
acatxnamedvirtue
approved these changes
Jun 25, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1130 +/- ##
==========================================
+ Coverage 82.48% 82.72% +0.23%
==========================================
Files 69 69
Lines 15482 15482
==========================================
+ Hits 12771 12808 +37
+ Misses 2711 2674 -37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the matrix complexity of https://github.com/trunk-io/analytics-cli/pull/1119/changes#diff-43905e5e2d18995dcc54587d628521bda13aff15d882e30ba5285305f3a9186e
While matrices are a good use case for variants, we have to quarantine each one of these individually in order to do a release, and the matrix is set up for fail-fast, so it's a pain to change things. Switching variant to OS to keep some of the same improvements.