[ready to merge] [TRUNK-17580] Add Google Cloud Build CI provider documentation#482
Merged
trunk-staging-io[bot] merged 7 commits intoMay 7, 2026
Merged
Conversation
|
😎 Merged successfully - details. |
New CI provider page with setup instructions for Google Cloud Build integration, including GCP Secret Manager configuration, Cloud Build triggers, required environment variables, and example cloudbuild.yaml configurations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
samgutentag
force-pushed
the
sam-gutentag/google-cloud-build-ci-provider
branch
from
8b6f204 to
b8c8ca1
Compare
Member
Author
|
Triage status (2026-05-05): merge conflicts with main in |
Member
Author
|
Verification status (2026-05-06): Verified: customers can use this. Ready to publish.
Suggested next action: replace the placeholder |
…loud-build-ci-provider # Conflicts: # flaky-tests/get-started/ci-providers/README.md
…loud-build-ci-provider
…loud-build-ci-provider
…d fix vale - Switch the cloudbuild.yaml example from the trunk launcher (./trunk flakytests upload) to the direct binary download pattern (./trunk-analytics-cli upload) used by every other CI provider page and matched in the analytics-cli reference impl - Reword the BUILD_ID env var description so vale stops flagging the repeated build word Note: google-cloud-build.png icon for the CI providers grid card on the README still needs to be added to .gitbook/assets/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…roviders grid Adds the missing google-cloud-build.png asset (1600x1000 white canvas matching peer CI provider icons) and updates the CI providers card grid on the README so the Google Cloud Build entry renders with a cover image instead of an empty cell. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Claude finished @samgutentag's task in 3m 2s —— View job Review summaryRead all four changed files and compared against peer CI-provider pages (CircleCI, Buildkite, GitLab, Bamboo, etc.) for consistency. Posted six inline comments — the two on Findings
Blocking
Non-blocking polish
Other observations (no inline)
|
samgutentag
changed the title
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Address all six unresolved review threads on the PR: - summary.md: move Google Cloud Build below GitLab to match alphabetical ordering used by the README card grid - google-cloud-build.md: rename Trunk Uploader CLI to Trunk Analytics CLI for consistency with peer CI provider pages - google-cloud-build.md: replace raw filename link text with descriptive text (Test Frameworks, Trunk Analytics CLI) - google-cloud-build.md: drop COMMIT_SHA and REPO_FULL_NAME from the YAML example so the env vars match the documented Required Environment Variables table - google-cloud-build.md: add the standard platform-binary callout that every other CI provider page includes after the examples Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Claude finished @samgutentag's task in 1m 26s —— View job Review summary (re-review after
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
trunk-staging-io
Bot
deleted the
sam-gutentag/google-cloud-build-ci-provider
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flaky-tests/get-started/ci-providers/google-cloud-build.mdcloudbuild.yamlconfigurationTRIGGER_NAME,PROJECT_ID,BUILD_ID,BRANCH_NAME,_HEAD_BRANCH,_PR_NUMBER) — these must be explicitly passed since Cloud Build does not auto-provide them to build stepssummary.mdtable of contentsLinear tickets
Engineering authors
Context links
Files changed
flaky-tests/get-started/ci-providers/google-cloud-build.md(new)flaky-tests/get-started/ci-providers/README.md(updated card grid)summary.md(added ToC entry)Open questions
google-cloud-build.pngas the card cover image. Dylan submitted trunk2 PR #2861 for the UI icon, but a docs-ready PNG for the GitBook card grid needs to be added to.gitbook/assets/. Without this image, the card will render without a cover.trunk-analytics-clidirectly. This PR uses the./trunk flakytests uploadpattern consistent with all other CI provider docs. Confirm this is correct for Google Cloud Build (the Trunk launcher should auto-detect the platform the same way).Test plan
summary.mdentry appears in correct alphabetical positioncloudbuild.yamlis syntactically validgoogle-cloud-build.pngicon to.gitbook/assets/Generated with Claude Code