docs(merge-queue): document metrics drill-down PR list#555
docs(merge-queue): document metrics drill-down PR list#555trunk-staging-io[bot] merged 5 commits intomainfrom
Conversation
Adds a section to the Metrics and Monitoring page describing how to click into a chart data point to view the individual PRs that make up that metric, with filter options for date range, conclusion, and impacted targets. Source: trunk2 PR #3539 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
😎 Merged successfully - details. |
|
Claude finished @samgutentag's task in 1m 12s —— View job PR Review
SummaryThe PR adds a Blocking: Duplicate section Recommended fix: Move the new Minor: Capitalization + wording (line 151)
See inline comment at line 151 for a suggested replacement. |
|
Triage status (2026-05-05): up to date with main. Needs review before merge. |
|
Claude finished @samgutentag's task in 1m 25s —— View job PR Review
SummaryThe diff to Blocking — duplicate section (line 150) Non-blocking — capitalization + wording (line 152)
Non-blocking — em-dash consistency (lines 160–162) Net: content is accurate and the filter info is the right addition — the structural duplication is the one thing that should block merge. |
|
Verification status (2026-05-07): Verified: customers can use this. Ready to publish.
Branch is up to date with main. Note: original draft documented filter controls that do not exist in the implementation; corrected in |
The original PR added a "### Drill into a metrics data point" section that mostly duplicated the existing "### Drill down into metrics" section above and described filter UI that does not exist. Verified against trunk2: merge-metrics-pr-list.tsx (381 lines) has no filter widgets. The conclusion and impactedTargets URL params are set by the drill-down click flow on the Health charts, not by user-editable controls on the PR list page. Replaced the duplicate section with a sentence on the actual page features: Back to Health navigation (lines 324, 358) and the 2,500-row truncation behavior (constants: MAX_ITEMS = 2_500, FETCH_PAGE_SIZE = 250). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Claude finished @samgutentag's task in 1m 37s —— View job PR Review
SummaryCommit
The new content is genuinely additive: it documents the date-range subtitle, the Back to Health link, and the 2,500-PR truncation behavior — useful page-level details that weren't covered by the existing subsections. Minor prose nit (non-blocking)The first sentence reads slightly ambiguously:
A reader scanning quickly could parse "shows … a Back to Health link" as if the link is also rendered as a subtitle. Splitting the sentence (or replacing the second Not worth blocking on — current phrasing is understandable on a careful read. NetLooks good to ship. Content is accurate, placement matches the surrounding section's structure, and prior structural concerns are addressed. |

Summary
Source
Test plan