Skip to content

docs(chrome-extension): hide Celebration setting behind an easter-egg disclosure#639

Merged
trunk-staging-io[bot] merged 2 commits intomainfrom
sam-gutentag/celebration-mode-easter-egg
May 7, 2026
Merged

docs(chrome-extension): hide Celebration setting behind an easter-egg disclosure#639
trunk-staging-io[bot] merged 2 commits intomainfrom
sam-gutentag/celebration-mode-easter-egg

Conversation

@samgutentag
Copy link
Copy Markdown
Member

Summary

  • Wraps the Celebration extension setting (the opt-in confetti burst) in a closed <details> block
  • Summary text reads "Have you turned on Celebration Mode?" so the disclosure functions as a discovery prompt rather than a labeled section
  • Drops the explicit ### Extension settings heading since the section was a single easter-egg setting

Context

Follow-up to #626 (Celebration setting docs). Treating it as a hidden discovery on the extension page makes the reveal more fun for readers who poke around, rather than calling it out under a regular heading.

Test plan

  • Verify the <details> renders as a closed disclosure in GitBook preview, with "Have you turned on Celebration Mode?" as the bold summary
  • Click to expand and confirm the access instructions, settings table, and reduced-motion note all render correctly inside
  • Confirm the next section (### Frequently asked questions) still flows correctly after the disclosure

… disclosure

The Extension settings section had only one entry (Celebration Mode),
which is itself an opt-in confetti easter egg. Wrap it in a closed
<details> block whose summary asks "Have you turned on Celebration
Mode?" so the reveal stays a fun discovery for readers who poke around
the extension page.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@trunk-staging-io
Copy link
Copy Markdown

trunk-staging-io Bot commented May 7, 2026

😎 Merged successfully - details.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 7, 2026

Claude finished @samgutentag's task in 1m 13s —— View job


Review

  • Read PR diff and changed file
  • Compared against repo style conventions and sibling pages
  • Checked typos, grammar, and formatting
  • Posted review

Summary: Small, focused change. Removes the ### Extension settings H3 and wraps the Celebration block in a closed <details> so it functions as a hidden discovery prompt. Implementation is clean and matches the intent from the PR body.

No blocking issues. A few non-blocking notes below.

Typos / grammar / formatting

Nothing flagged — the moved content is identical, and the new summary line reads correctly.

Style & consistency

  • ✅ The <details><summary><strong>…</strong></summary> pattern matches the FAQ disclosures further down (merge-queue/chrome-extension.md:79–109). Using a plain <details> (no open) instead of <details open> is correct here — closed-by-default is what makes it an easter-egg rather than another expanded card.
  • ✅ Removing the ### Extension settings heading removes the entry from the GitBook right-hand TOC, which is consistent with the easter-egg intent.

Non-blocking observations

  1. Visual placement under "Authentication and security." With the H3 gone, the disclosure now sits as a bare block immediately after the security bullets and before ### Frequently asked questions. In rendered output, a reader scanning the page may briefly read the closed disclosure as part of the security section. If you want to make the boundary a bit more obvious without restoring the heading, a horizontal rule (---) above the <details> would visually break the security section from the easter-egg without adding it back to the TOC. Optional — current placement is fine if the disclosure's bold summary is enough of a separator in GitBook's rendering.

  2. Setting name vs. summary phrasing. The setting in the table is called Celebration (single word), while the summary asks about "Celebration Mode." That's a small naming mismatch — readers who toggle it on will see a checkbox labeled "Celebration," not "Celebration Mode." Minor, and the playful summary phrasing arguably reads better than "Have you turned on Celebration?", so this is a judgment call. Worth a quick look in GitBook preview to make sure it doesn't feel jarring.

  3. Test plan item 1 notes "bold summary" — confirmed: <strong> is used inside <summary>, matching the FAQ disclosures.
    · Branch

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

Refile the Celebration Mode disclosure under Frequently asked
questions as the last entry, with the question reformatted to
"How do I enable Celebration Mode?" so it matches the style of the
other FAQ items. Keep it as a closed details block while the rest of
the FAQ stays open by default, so the reveal-on-click feels like a
small surprise tucked behind a question rather than a labeled
section.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 7, 2026

Claude finished @samgutentag's task in 1m 27s —— View job


Review

  • Read PR diff and changed file
  • Check typos, grammar, and formatting
  • Compare against repo style conventions
  • Post review feedback

Summary: Two-commit PR. The first commit wrapped Celebration in a closed <details> block under a "Have you turned on Celebration Mode?" summary. The second commit (347507c) moved the disclosure into the Frequently asked questions section as a closed-by-default entry titled "How do I enable Celebration Mode?". The current state is a clean, focused change — the standalone ### Extension settings H3 is gone and the easter egg lives at the bottom of the FAQ.

No blocking issues. A few non-blocking notes below.

Typos / grammar / formatting

Nothing flagged. The moved content is byte-identical to what was in the previous "Extension settings" section, and the new FAQ summary line reads correctly.

Style & consistency

  • ✅ The four pre-existing FAQ entries use <details open> (lines 65, 73, 81, 89). The new Celebration entry intentionally uses plain <details> (line 97) — closed-by-default is what makes it an easter egg, so the divergence is correct.
  • <summary><strong>…</strong></summary> matches the surrounding FAQ pattern.
  • ✅ Removing ### Extension settings removes the entry from the GitBook right-hand TOC, consistent with the easter-egg intent.
  • ✅ Placement at the end of the FAQ section is good — the question is colocated with similarly-phrased "How do I…?" / "Why don't I…?" entries, so it doesn't look out of place when collapsed.

Non-blocking observations

  1. PR description is now stale. The body still describes the first-commit state ("Summary text reads 'Have you turned on Celebration Mode?'"). The second commit renamed the summary to "How do I enable Celebration Mode?" and relocated the block into the FAQ. Worth updating the PR description before merge so reviewers and the merge commit message reflect the final shape — though this is purely cosmetic.

  2. Celebration vs Celebration Mode naming mismatch persists. Flagged on the previous review and still present: the summary says "Celebration Mode" while the settings table label is just "Celebration." A reader who clicks through to the extension's Options page will see a checkbox labeled "Celebration," not "Celebration Mode." Two ways to resolve, both fine:

    • Rephrase the summary to "How do I enable the Celebration setting?" (matches the table exactly), or
    • Leave as-is — "Celebration Mode" reads more naturally as a phrase, and the table column makes the actual setting label unambiguous once expanded.

    Judgment call; not blocking.

  3. Closed-by-default discoverability. Worth eyeballing in GitBook preview that the closed disclosure visually reads as a peer of the four expanded ones (rather than as an inert footer). The test plan covers this.

· Branch ·

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Claude code review passed.

@trunk-staging-io trunk-staging-io Bot merged commit 5d0504f into main May 7, 2026
7 checks passed
@trunk-staging-io trunk-staging-io Bot deleted the sam-gutentag/celebration-mode-easter-egg branch May 7, 2026 20:51
trunk-staging-io Bot pushed a commit that referenced this pull request May 7, 2026
#643)

## Summary

Pulls forward the small bits worth keeping from #588 (Eli's original
Chrome Extension docs PR), since the page itself has evolved well past
that draft via several subsequent merged PRs (#593, #595, #598, #626,
#639).

## Changes

- Add a frontmatter `description:` so GitBook renders proper page
metadata for SEO and navigation previews
- Add an inline pointer to the Submit and cancel pull requests reference
page after the Submit steps, so readers can drill into the full
lifecycle from this entry point
- Replace the FAQ link to a hard-coded GitHub commit URL with a relative
path to `getting-started/`, matching the rest of the docs

## Test plan

- [ ] Verify the page metadata description renders in GitBook preview
- [ ] Confirm the new inline link to `using-the-queue/reference.md`
resolves correctly
- [ ] Confirm the FAQ link to `getting-started/` resolves correctly

## Related

- Closes #588 in spirit (that PR's content has been superseded by main;
this picks up the pieces still worth merging)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant