-
Notifications
You must be signed in to change notification settings - Fork 13
Remove stacked PR references #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,6 @@ | |
| * [Submit and cancel pull requests](merge-queue/using-the-queue/reference.md) | ||
| * [Monitor queue status](merge-queue/using-the-queue/monitor-queue-status.md) | ||
| * [Handle failed pull requests](merge-queue/using-the-queue/handle-failed-pull-requests.md) | ||
| * [Work with stacked pull requests](merge-queue/using-the-queue/stacked-pull-requests.md) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the page still remains but we don't link to it |
||
| * [Emergency pull requests](merge-queue/using-the-queue/emergency-pull-requests.md) | ||
| * [Force merge](merge-queue/using-the-queue/force-merge.md) | ||
| * [Integration for Slack](merge-queue/integration-for-slack.md) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orphaned page —
merge-queue/using-the-queue/stacked-pull-requests.mdstill existsAfter this PR, no markdown file links to
stacked-pull-requests.md(the entry is removed fromsummary.md,using-the-queue/README.md,reference.md,chrome-extension.md,trunk-sudo-app.md, andconfigure-branch-protection.md), but the 12 KB source file is still in the repo and still describes/trunk stackas a supported feature.If the goal of this PR is to retire the feature from the docs, the page should either be deleted or replaced with a short deprecation/redirect notice. Leaving an orphan markdown file means:
If keeping the URL alive intentionally (e.g. for SEO/inbound links), consider trimming the file down to a short "this feature has been removed" notice instead. Otherwise
git rmit.Fix this →
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentional