Skip to content

docs(flaky-tests): add skipped-test, slow-test, and new-test monitor pages#28

Merged
max-trunk merged 1 commit into
mainfrom
sam-gutentag/flaky-tests-new-monitors
May 28, 2026
Merged

docs(flaky-tests): add skipped-test, slow-test, and new-test monitor pages#28
max-trunk merged 1 commit into
mainfrom
sam-gutentag/flaky-tests-new-monitors

Conversation

@samgutentag
Copy link
Copy Markdown
Member

@samgutentag samgutentag commented May 18, 2026

Summary

  • Adds three new monitor docs pages: skipped-test-monitor.mdx, slow-test-monitor.mdx, new-test-monitor.mdx
  • Updates detection/index.mdx monitor types table to include the three new monitors
  • Updates docs.json nav to include the new pages

Source

Test plan

  • Check Mintlify preview link (posted on the PR by the Mintlify GitHub app)
  • Verify all three new pages render correctly
  • Verify monitor types table in index.mdx shows all six monitors

Generated by Claude Code

@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented May 18, 2026 •
edited
Loading

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
trunk 🟢 Ready View Preview May 18, 2026, 10:46 PM

@samgutentag samgutentag changed the title docs(flaky-tests): add skipped-test, slow-test, and new-test monitor pages [feature not live] docs(flaky-tests): add skipped-test, slow-test, and new-test monitor pages May 19, 2026
@samgutentag
Copy link
Copy Markdown
Member Author

samgutentag commented May 19, 2026 •
edited
Loading

Verification status (2026-05-26): blocked

Eng PR not merged. Hold.

  • Eng PRs:
    • trunk2#3978 (stacked merge of #3967, #3969, #3970 -- service endpoints): MERGED 2026-05-18
    • trunk2#3959 (ClickHouse migrations): MERGED 2026-05-14
    • trunk2#4008, #4012, #4015 (frontend CRUD operations): all CLOSED without merge on 2026-05-26
    • trunk#32245, #32248, #32249 (pipeline integration in monolith): all CLOSED without merge
    • trunk2#4022 (E2E test coverage): still OPEN
  • Flag: none
  • Linear: TRUNK-18025, TRUNK-18026, TRUNK-18027 (marked "Done" 2026-05-26, but frontend CRUD PRs were closed, not merged)
  • Signals: backend service endpoints and migrations shipped, but the frontend CRUD PRs for creating/viewing these monitors in the UI were closed without merging. Customers cannot create or view skipped-test, slow-test, or new-test monitors in the web app. The monolith pipeline PRs that would actually run these monitors were also closed without merge.

Hold until the frontend CRUD and pipeline integration ship. The Linear tickets being marked "Done" appears inconsistent with the closed-not-merged PRs; verify with eng whether this feature shipped via a different path.

Label: awaiting eng.

@samgutentag samgutentag added the pending Verify docs PR: eng merged but flag off in prod. Hold off. label May 19, 2026
@samgutentag samgutentag changed the title [feature not live] docs(flaky-tests): add skipped-test, slow-test, and new-test monitor pages docs(flaky-tests): add skipped-test, slow-test, and new-test monitor pages May 19, 2026
@samgutentag samgutentag added awaiting eng Verify docs PR: eng PR not merged. Hold. and removed pending Verify docs PR: eng merged but flag off in prod. Hold off. labels May 26, 2026
@claude @samgutentag
docs(flaky-tests): add new-test, skipped-test, and slow-test monitor …
0634689 
…pages

Documents three new monitor types added in trunk2 PR #3978 (stack of
#3967, #3969, #3970). Updates the detection index monitor types table
and adds individual pages for each monitor following the existing
failure-count-monitor format.

Co-Authored-By: Claude <noreply@anthropic.com>
@samgutentag samgutentag force-pushed the sam-gutentag/flaky-tests-new-monitors branch from 5c62b8e to 0634689 Compare May 26, 2026 18:59
@samgutentag Claude
Copy link
Copy Markdown
Member Author

samgutentag commented May 27, 2026

Verification status (May 27, 2026): live

Verified: customers can use this. Ready to publish.

  • Eng PR: trunk-io/trunk2#4021 (stack of #4008, #4012, #4015) -- merged 2026-05-26
  • Flag: none
  • Signals:
    • trunk-io/trunk2#4021 state: merged (merged_at: 2026-05-26T14:57:36Z)
    • trunk-io/trunk2#4008 (new-test monitor CRUD): closed via stack merge
    • trunk-io/trunk2#4012 (skipped-test monitor CRUD): closed via stack merge
    • trunk-io/trunk2#4015 (slow-test monitor CRUD): closed via stack merge
    • Feature flag search (useFeatureFlag, useFlag, enableNew, enableSkipped, enableSlow, featureFlag) across the full stack diff and trunk-io/trunk2 codebase: no flags found
    • Monitor dialogs (NewTestMonitorDialog, SkippedTestMonitorDialog, SlowTestMonitorDialog) imported directly in monitors-table.tsx with no flag gating

Mark this PR ready and merge to publish the docs.

Generated by Claude Code

@samgutentag samgutentag marked this pull request as ready for review May 27, 2026 10:58
@samgutentag samgutentag added ready to merge Verify docs PR: customers can use this. Ready to publish. and removed awaiting eng Verify docs PR: eng PR not merged. Hold. labels May 27, 2026 — with Claude
@samgutentag Claude
Copy link
Copy Markdown
Member Author

samgutentag commented May 27, 2026

Verification status (May 27, 2026): pending

Eng merged but flag off in prod. Hold off.

Re-run after LaunchDarkly flag is ramped to 100% in production.

Generated by Claude Code

@samgutentag samgutentag added pending Verify docs PR: eng merged but flag off in prod. Hold off. and removed ready to merge Verify docs PR: customers can use this. Ready to publish. labels May 27, 2026 — with Claude
@samgutentag samgutentag marked this pull request as draft May 27, 2026 18:14
@max-trunk max-trunk marked this pull request as ready for review May 28, 2026 14:41
@max-trunk max-trunk merged commit e55d8b9 into main May 28, 2026
3 checks passed
@max-trunk max-trunk deleted the sam-gutentag/flaky-tests-new-monitors branch May 28, 2026 14:42
@samgutentag samgutentag mentioned this pull request May 28, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-trunk max-trunk max-trunk approved these changes

Assignees

No one assigned

Labels

pending Verify docs PR: eng merged but flag off in prod. Hold off.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samgutentag @max-trunk @claude