Skip to content

docs(flaky-tests): document fork PR uploads per-repo opt-in#33

Draft
samgutentag wants to merge 1 commit into
mainfrom
sam-gutentag/flaky-tests-fork-pr-uploads
Draft

docs(flaky-tests): document fork PR uploads per-repo opt-in#33
samgutentag wants to merge 1 commit into
mainfrom
sam-gutentag/flaky-tests-fork-pr-uploads

Conversation

@samgutentag
Copy link
Copy Markdown
Member

Summary

  • Adds a new "Uploading from Fork Pull Requests" section to flaky-tests/get-started/multiple-repositories.mdx
  • Explains how to enable the Fork PR Uploads toggle in repo settings to get a public repo identifier
  • Documents the workflow YAML change that uses public-repo-id instead of the org API token
  • Covers the two-part authorization model (opt-in + GitHub run verification)
  • Includes a warning about rotating the identifier if misused

Source

Test plan

  • Check Mintlify preview link (posted on the PR by the Mintlify GitHub app)
  • Verify the new section renders correctly (callout blocks, code block, warning)
  • Confirm the section flows correctly after "How Repository Identification Works"

Generated by Claude Code

Adds a new "Uploading from Fork Pull Requests" section to the
multiple-repositories page explaining how to enable the settings toggle,
copy the public repo identifier, and configure fork PR workflows to upload
test results without exposing the org API token.

Source: trunk-io/trunk2#3908

Co-Authored-By: Claude <noreply@anthropic.com>
@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented May 19, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
trunk 🟢 Ready View Preview May 19, 2026, 11:01 AM

@samgutentag samgutentag changed the title docs(flaky-tests): document fork PR uploads per-repo opt-in [blocked] docs(flaky-tests): document fork PR uploads per-repo opt-in May 19, 2026
@samgutentag
Copy link
Copy Markdown
Member Author

samgutentag commented May 19, 2026

Verification status (2026-05-19): blocked

Eng PR not merged. Hold.

  • Eng PR: trunk2#3908 (merged 2026-05-18). Cross-repo deps still OPEN:
    • analytics-cli#1086 (Support X-Trunk-Public-Repo-Id auth for fork PRs)
    • trunk#31970 (Accept X-Trunk-Public-Repo-Id on flaky-tests upload + quarantine endpoints)
  • Flag: none (no LaunchDarkly flag introduced in trunk2#3908)
  • Signals: trunk2 UI toggle ships ungated, but the documented workflow YAML depends on analytics-cli sending the new header and the monolith accepting it. Neither merged at this sweep.

Hold until analytics-cli#1086 and trunk#31970 merge.

Note: PR #35 also documents this feature with a slightly different scope. Coordinate which docs PR to merge.

Label: awaiting eng.

@samgutentag samgutentag added the awaiting eng Verify docs PR: eng PR not merged. Hold. label May 19, 2026
@samgutentag samgutentag changed the title [blocked] docs(flaky-tests): document fork PR uploads per-repo opt-in docs(flaky-tests): document fork PR uploads per-repo opt-in May 19, 2026
@samgutentag samgutentag added pending Verify docs PR: eng merged but flag off in prod. Hold off. and removed awaiting eng Verify docs PR: eng PR not merged. Hold. labels May 20, 2026 — with Claude
Copy link
Copy Markdown
Member Author

Verification status (May 20, 2026): pending

Eng merged but the end-to-end feature is not yet complete. The trunk2 frontend and API changes merged in #3908, but the legacy monolith (api.trunk.io) and analytics-cli changes are listed as cross-repo TODOs in the PR.

  • Eng PR: trunk-io/trunk2#3908 (merged 2026-05-18)
  • Flag: none (no explicit LaunchDarkly flag found)
  • Signals: trunk2#3908 merged; legacy monolith X-Trunk-Public-Repo-Id support pending; analytics-cli fork PR identifier pending

Hold until the cross-repo TODOs (monolith + analytics-cli) are shipped.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending Verify docs PR: eng merged but flag off in prod. Hold off.

Development

Successfully merging this pull request may close these issues.

2 participants