Skip to content

Update README.md#539

Merged
EliSchleifer merged 1 commit intotrunk-io:mainfrom
error9900:patch-1
Oct 26, 2023
Merged

Update README.md#539
EliSchleifer merged 1 commit intotrunk-io:mainfrom
error9900:patch-1

Conversation

@error9900
Copy link
Copy Markdown
Contributor

@error9900 error9900 commented Oct 26, 2023

List prettier for additional supported languages.

Supported languages listed here: https://prettier.io/docs/en/

List `prettier` for additional supported languages.
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Oct 26, 2023

⏱️ 4m total CI duration on this PR

Job Cumulative Duration Recent Runs
CodeQL-Build 2m 🟩
Trunk Check runner [linux] 52s 🟩
Repo Tests / Plugin Tests 46s 🟩
Detect changed files 6s 🟩
Aggregate Test Results 3s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@error9900 error9900 marked this pull request as ready for review October 26, 2023 09:05
@EliSchleifer EliSchleifer self-requested a review October 26, 2023 23:49
Copy link
Copy Markdown
Member

@EliSchleifer EliSchleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@EliSchleifer EliSchleifer merged commit 86d051c into trunk-io:main Oct 26, 2023
@error9900 error9900 deleted the patch-1 branch October 28, 2023 01:38
@TylerJang27
Copy link
Copy Markdown
Collaborator

TylerJang27 commented Nov 2, 2023

Do we want to list those in our README.md if we don't support those filetypes out of the box (all require plugins/extra packages)?

@EliSchleifer
Copy link
Copy Markdown
Member

EliSchleifer commented Nov 3, 2023 via email

@TylerJang27
Copy link
Copy Markdown
Collaborator

I stand corrected. These added file types are all ones we already support. Prettier has some other plugins that support additional filetypes or frameworks, but these are all included in the base and ones that we already have config for.

pat-trunk-io pushed a commit that referenced this pull request Jan 22, 2024
List `prettier` for additional supported languages.

Supported languages listed here: https://prettier.io/docs/en/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants