Update README.md#539
Merged
EliSchleifer merged 1 commit intotrunk-io:mainfrom Oct 26, 2023
error9900:patch-1
Merged
Conversation
List `prettier` for additional supported languages.
|
⏱️ 4m total CI duration on this PR
|
Collaborator
|
Do we want to list those in our README.md if we don't support those filetypes out of the box (all require plugins/extra packages)? |
Member
|
Any reason not to bring in those plugins by default?
…On Wed, Nov 1, 2023 at 5:38 PM Tyler Jang ***@***.***> wrote:
Do we want to list those in our README.md if we don't support those
filetypes out of the box (all require plugins/extra packages)?
—
Reply to this email directly, view it on GitHub
<#539 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJVCPSKFLZCVYA735BZLP3YCLTP3AVCNFSM6AAAAAA6QZ2FL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZHA4DCMBWGM>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Collaborator
|
I stand corrected. These added file types are all ones we already support. Prettier has some other plugins that support additional filetypes or frameworks, but these are all included in the base and ones that we already have config for. |
pat-trunk-io
pushed a commit
that referenced
this pull request
Jan 22, 2024
List `prettier` for additional supported languages. Supported languages listed here: https://prettier.io/docs/en/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List
prettierfor additional supported languages.Supported languages listed here: https://prettier.io/docs/en/