Skip to content

Add tofu tool and linter#707

Merged
det merged 7 commits into
mainfrom
det/add_tofu
Mar 21, 2024
Merged

Add tofu tool and linter#707
det merged 7 commits into
mainfrom
det/add_tofu

Conversation

@det
Copy link
Copy Markdown
Contributor

@det det commented Mar 21, 2024

This is a fork of terraform. Just copied the terraform files and replaced terraform with tofu when needed / fixed the download / changed the version / simplified the backwards compat stuff.

Chris Clearwater added 2 commits March 21, 2024 12:59
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Mar 21, 2024

⏱️ 53m total CI duration on this PR
Job Cumulative Duration Recent Runs
Windows Linter Tests 10m 🟩🟩🟩🟩 (+1 more)
Windows Tool Tests 9m 🟥🟩🟩🟩 (+1 more)
Linter Tests macOS 8m 🟩🟩🟩🟩🟩 (+1 more)
CodeQL-Build 7m 🟩🟩🟩🟩🟩 (+1 more)
Trunk Check runner [linux] 6m 🟩🟩🟩🟩🟩 (+1 more)
Linter Tests Linux 5m 🟩🟩🟩🟩🟩 (+1 more)
Tool Tests (macOS) 3m 🟥🟥🟩🟩🟩 (+1 more)
Repo Tests / Plugin Tests 2m 🟩🟩🟩🟩🟩 (+1 more)
Tool Tests (Linux) 2m 🟥🟥🟩🟩🟩 (+1 more)
Detect changed files 41s 🟩🟩🟩🟩🟩 (+1 more)
Aggregate Test Results 20s 🟥🟥🟩🟩🟩 (+1 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

@det det changed the title Add tofu tool and linter (fork of terraform) Add tofu tool and linter Mar 21, 2024
Chris Clearwater added 2 commits March 21, 2024 13:59
@det det requested a review from TylerJang27 March 21, 2024 21:02
Copy link
Copy Markdown
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please fix the readme copy

Comment thread README.md Outdated
Comment thread linters/tofu/tofu.test.ts
const preCheck = (driver: TrunkLintDriver) => {
const trunkYamlPath = ".trunk/trunk.yaml";
const currentContents = driver.readFile(trunkYamlPath);
const sqlfluffRegex = /- tofu@(.+)\n/;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this should be renamed (in the terraform test too 🙃 )

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 14 instances of this, will break into its own PR :)

Chris Clearwater added 2 commits March 21, 2024 14:17
@det det merged commit 82587de into main Mar 21, 2024
@det det deleted the det/add_tofu branch March 21, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants