Conversation
⏱️ 2h 5m total CI duration on this PR
|
TylerJang27
reviewed
Apr 1, 2024
Collaborator
TylerJang27
left a comment
TylerJang27
left a comment
There was a problem hiding this comment.
Some cleanup and sanity check comments
Comment on lines
+6
to
+8
| downloads: | ||
| - version: 2.5.1 | ||
| gpg: CBB3D576F2A0946F |
Collaborator
There was a problem hiding this comment.
Is this missing a URL or is this sufficient?
Contributor
Author
There was a problem hiding this comment.
this is sufficient - we are just using the gpg key to allow another php runtime tool to download this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.