Update commitlint v17 -> v19#726
Conversation
⏱️ 6m total CI duration on this PR
|
| "commitlint.config.js", | ||
| "module.exports = {extends: ['@commitlint/config-conventional']}", | ||
| "commitlint.config.mjs", | ||
| "export default {extends: ['@commitlint/config-conventional']}", |
There was a problem hiding this comment.
Not sure how renaming the file and using export default should be handled by trunk when upgrading to this version. I.e. how to handle breaking changers in tools supported by trunk?
There was a problem hiding this comment.
I suppose its up to the user to configure the commitlint config file. I’ll need to update the commitlint readme here: https://github.com/trunk-io/plugins/tree/main/actions/commitlint
There was a problem hiding this comment.
Thanks for the PR @rriski and for bringing this to our attention! I'll speak with the team about if there is any better way we can handle the update process for users. I think we will probably want to go ahead and land this, and also update the readme instructions, as you mentioned, but I'll follow-up again shortly.
v19 contains breaking changes, see: - https://github.com/conventional-changelog/commitlint/blob/master/CHANGELOG.md#1900-2024-02-27
TylerJang27
left a comment
TylerJang27
left a comment
There was a problem hiding this comment.
Thanks for the PR! I will call this out in our next release as a breaking change
2 participants
v19 contains breaking changes, see: