Write descriptions for each linter#751
Merged
Merged
Conversation
⏱️ 6h 3m total CI duration on this PR
|
TylerJang27
reviewed
Apr 19, 2024
Collaborator
TylerJang27
left a comment
TylerJang27
left a comment
There was a problem hiding this comment.
Some notes, mainly nits and unifying the grammar
| - name: buildifier | ||
| files: [starlark, bazel-build, bazel-workspace] | ||
| tools: [buildifier] | ||
| description: Formatter for Bazel-related files |
TylerJang27
approved these changes
Apr 23, 2024
Collaborator
TylerJang27
left a comment
TylerJang27
left a comment
There was a problem hiding this comment.
Some minor cleanup :)
| - name: git-diff-check | ||
| files: [ALL] | ||
| description: Check for trailing whitespace | ||
| description: Check for git conflicts |
Collaborator
There was a problem hiding this comment.
Suggested change
| description: Check for git conflicts | |
| description: Checks for git conflicts |
| files: [go] | ||
| tools: [golangci-lint] | ||
| description: A fast Go linters runner | ||
| description: A power Go linter runner |
Collaborator
There was a problem hiding this comment.
Suggested change
| description: A power Go linter runner | |
| description: A powerful Go linter runner |
| files: [renovate-config] | ||
| tools: [renovate] | ||
| description: Checks Renovate configuration files | ||
| description: Validate Renovate configuration files |
Collaborator
There was a problem hiding this comment.
Suggested change
| description: Validate Renovate configuration files | |
| description: Validates Renovate configuration files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very tedious task; aided by grabbing slogans off of linter websites + GitHub copilot.
The variation in style is intentional. Let me know what your thoughts are.