Not showing binary request data by Content-Type for httpclient adapter#53
Conversation
trusche
left a comment
trusche
left a comment
There was a problem hiding this comment.
Thanks for this, but it's breaking a bunch of tests, and also introduces differences between httpclient and the other adapters. I'll happily accept this if it's consistent across all adapters and comes with a new test for the new behaviour.
| def log_data(data) | ||
| def log_data(data, content_type = nil) | ||
| return if config.compact_log || !config.log_data | ||
| unless text_based?(content_type) |
There was a problem hiding this comment.
This is breaking all other adapters, since they're not passing in the request content type, and the default nil will not be treated as text based.
|
Fix test for ethon, excon, http, patron adapters. |
|
Cheers. It looks like Net::HTTP passes the content type differently to post requests (with a symbol |
2 participants
No description provided.