Mask sensitive information

[bustikiller]

We need to mask some sensitive information such as credentials and API tokens.

[trusche]

Hi @bustikiller, thanks for the PR, and that's a cool feature in principle.

I'll have to spend some time reviewing it and thinking through how this would cover the most common use cases - this implementation, at a glance, would only filter out key=value pairs, and for example not work on quoted value strings or JSON. If you want to take a shot at that, go ahead, otherwise I'll take it from here, but it will take a bit to get merged then.

[trusche]

I'd use the term "mask" instead of "filter", it describes better what this is doing. "Filtering" implies removing, which could be misunderstood. "Masking" just means "don't show" more specifically.

Could we add test cases and implementation to support JSON as well as quoted strings as values?

[bustikiller]

@trusche thanks for the fast feedback.

I will try to find some time to make this work with keywords inside JSON. However, I don't understand what you mean by "will not work on quoted string values". Could you please provide an example?

Thanks

[bustikiller]

@trusche I added tests with some JSON-body examples that came to my mind and fixed the masked_data method accordingly.

[trusche]

Cool, thanks. I'll tweak this a bit, should go live shortly.