Skip to content

Graylog adaptation#83

Merged
trusche merged 3 commits intotrusche:masterfrom
Meat-Chopper:graylog_adaptation
Nov 14, 2019
Merged

Graylog adaptation#83
trusche merged 3 commits intotrusche:masterfrom
Meat-Chopper:graylog_adaptation

Conversation

@Meat-Chopper
Copy link
Copy Markdown
Contributor

No description provided.

@Meat-Chopper Meat-Chopper force-pushed the graylog_adaptation branch 2 times, most recently from c226090 to 935f294 Compare November 12, 2019 07:41
@trusche
Copy link
Copy Markdown
Owner

trusche commented Nov 13, 2019

Hiya @Meat-Chopper, this is great, thanks for the PR. If you could add some tests that cover the new feature, I'd be happy to merge this.

@Meat-Chopper
Copy link
Copy Markdown
Contributor Author

Hello @trusche, the tests have been added

Copy link
Copy Markdown
Owner

@trusche trusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments...

Comment thread spec/lib/http_client_spec.rb
Comment thread spec/spec_helper.rb Outdated
@Meat-Chopper Meat-Chopper requested a review from trusche November 14, 2019 10:06
@trusche trusche merged commit 29e46da into trusche:master Nov 14, 2019
@Meat-Chopper
Copy link
Copy Markdown
Contributor Author

Thank you!

@trusche
Copy link
Copy Markdown
Owner

trusche commented Nov 14, 2019

Published as v1.3.3. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants