Add serde implementations for platforms and release v0.6.0-rc.2#78
Open
robin-nitrokey wants to merge 4 commits into
Open
Add serde implementations for platforms and release v0.6.0-rc.2#78robin-nitrokey wants to merge 4 commits into
robin-nitrokey wants to merge 4 commits into
Conversation
robin-nitrokey
commented
May 22, 2026
| x5c, | ||
| })) | ||
| } | ||
| _ => Ok(AttestationStatement::None(NoneAttestationStatement {})), |
Member
Author
There was a problem hiding this comment.
I think it would be more accurate to only return AttestationStatement::None if the map does not have any entries and return an error otherwise. What do you think?
Contributor
There was a problem hiding this comment.
Yes, this seems better, a non suppported attestation format should be rejected not considered as null.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #75.
@0x0ece The reason I did not include this in rc.1 is that I wanted to discuss the feature name but did not want to delay the rc for it as it does not affect fido-authenticator so it does not block the PRs there.
The name
test-clientmakes sense from the perspective of the solo2 test suite, but IMHO not for ctap-types. What do you think about calling the featureplatform-serdebecause it provides the serde trait implementations required by platforms but not by authenticators?