Finalize machines #104
Draft
Finalize machines #104
+300
−215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Jakob-Naucke
force-pushed
the
autodelete
branch
from
ede98db to
7144f17
Compare
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
for reuse outside of main.rs Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Small line savings but will grow with further use Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Delete and unmount secret upon deletion Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Not really something specifiers decide. Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Jakob-Naucke
force-pushed
the
autodelete
branch
from
7144f17 to
9d40b83
Compare
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Jakob-Naucke
force-pushed
the
autodelete
branch
from
5adb6eb to
62d2c57
Compare
Contributor
Author
|
to draft, setting statuses doesn't work like that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete and unmount secret upon deletion. Make machines immutable. Make IP a status field, not a spec.