-
Notifications
You must be signed in to change notification settings - Fork 8
ci: Add must-gather #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci: Add must-gather #149
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| @@ -0,0 +1,29 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we collect also our crs? Like approved images, images and the trusted execution clusters
must-gather/gather
Outdated
| DEPLOYMENTS=("trusted-cluster-operator" "register-server" "trustee-deployment") | ||
| NAMESPACES=$(oc get namespaces -o jsonpath='{.items[*].metadata.name}') | ||
|
|
||
| for ns in ${NAMESPACES}; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also collect the kubevirt logs, it can give helpful information why a VM might fail to start in the tests.
must-gather/gather
Outdated
|
|
||
| oc get virtualmachines -n "${ns}" -o yaml &> "${COLLECTION_PATH}/virtualmachines-${ns}.yml" | ||
|
|
||
| VIRT_LAUNCHER_PODS=$(oc get pods -n "${ns}" -o name 2> /dev/null | grep "^pod/virt-launcher-") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can get the pods by label, something like -l kubevirt.io=virt-launcher
must-gather/gather
Outdated
|
|
||
| VIRT_LAUNCHER_PODS=$(oc get pods -n "${ns}" -o name 2> /dev/null | grep "^pod/virt-launcher-") | ||
| for pod in ${VIRT_LAUNCHER_PODS}; do | ||
| oc logs "${pod}" -n "${ns}" -c guest-console-log &> "${COLLECTION_PATH}/logs/${pod}-${ns}-guest-console.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, collect all the containers, in virt-launcher pod. Also, the compute container can have really important information
must-gather/gather
Outdated
| fi | ||
| done | ||
|
|
||
| oc get virtualmachines -n "${ns}" -o yaml &> "${COLLECTION_PATH}/virtualmachines-${ns}.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, get also the VMI objects, there are different information reported on VM and VMI objects
7ff6301 to
ff62729
Compare
|
Updated. My OKD cluster acted up though so I still need to re-test it on that (kind went fine). |
Log pods and CRs Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
ff62729 to
54bc522
Compare
|
@Jakob-Naucke: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Log pods and VM descriptions and console outputs.
If this is accepted, I can push it to our registry. Tested with OKD.