Skip to content

Conversation

@iroykaufman
Copy link

This commit updates the test utils to support running trusted execution cluster tests on the OpenShift platform.

To execute these tests on OpenShift, the following environment variables must be configured:

  • REGISTRY: The repository location of the container image.
  • TAG: The specific tag of the container image. (default latest)
  • CLUSTER_URL: The API URL of the target cluster.
  • PLATFORM: Set this to openshift.

example: RUST_LOG=info REGISTRY=quay.io PLATFORM=openshift CLUSTER_URL=<SECRET_URL> cargo test --test trusted_execution_cluster -- --no-capture

This commit updates the test utils to support running trusted execution
cluster tests on the OpenShift platform.

To execute these tests on OpenShift, the following environment variables
must be configured:

- REGISTRY:    The repository location of the container image.
- TAG:         The specific tag of the container image.
- CLUSTER_URL: The API URL of the target cluster.
- PLATFORM:    Set this to 'openshift'.

Signed-off-by: Roy Kaufman <rkaufman@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iroykaufman

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2026

@iroykaufman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/infra-provision-verify f6c77b2 link true /test infra-provision-verify
ci/prow/operator-lifecycle-verify f6c77b2 link true /test operator-lifecycle-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Comment on lines -265 to +268
std::fs::create_dir_all(&rbac_temp_dir)?;
std::fs::create_dir_all(&crd_temp_dir)?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trailing spaces

Comment on lines -325 to +331

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can drop

&self.manifests_dir,
"-image",
"localhost:5000/trusted-execution-clusters/trusted-cluster-operator:latest",
&format!("{repo}/trusted-execution-clusters/trusted-cluster-operator:{tag}"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Makefile defines the registry as quay.io/trusted-execution-clusters, so I think this (and all below) should be

Suggested change
&format!("{repo}/trusted-execution-clusters/trusted-cluster-operator:{tag}"),
&format!("{repo}/trusted-cluster-operator:{tag}"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants