Test improvments

[yairpod]

For easier testing I am adding make targets to run the attestation and trusted_execution_cluster seperatly, and an env variable TEST_TIMEOUT_MULTIPLIER that will increase the timeouts of all tests for slower systems.

Summary by Sourcery

Add configurable test timeout scaling and new make targets for running specific integration test suites.

New Features:

• Introduce TEST_TIMEOUT_MULTIPLIER environment variable to scale timeouts and durations across integration tests.
• Add dedicated make targets for running only attestation or trusted_execution_cluster tests.

Enhancements:

• Refactor existing test timeouts to use shared scaling helpers for durations.
• Document the new timeout multiplier and targeted test make targets in the tests README.

[sourcery-ai]

Reviewer's Guide

Adds an environment-driven test timeout scaling utility and wires it through long-running integration tests, plus introduces dedicated Make targets to run attestation and trusted_execution_cluster tests separately and documents their usage.

Flow diagram for new test Make targets and timeout multiplier

flowchart LR
    dev[Developer] --> attestation_tests[make attestation-tests]
    dev[Developer] --> trusted_cluster_tests[make trusted_execution_cluster-tests]

    attestation_tests --> cargo_attestation[cargo test --test attestation --features virtualization]
    trusted_cluster_tests --> cargo_trusted[cargo test --test trusted_execution_cluster --features virtualization]

    env_timeout[TEST_TIMEOUT_MULTIPLIER env var] --> timeout_util[Test timeout scaling utility]

    cargo_attestation --> timeout_util
    cargo_trusted --> timeout_util

Loading

File-Level Changes

Change	Details	Files
Introduce environment-based timeout scaling helpers and use them across long-running tests.	Add TEST_TIMEOUT_MULTIPLIER_ENV constant and timeout_multiplier() helper to read and parse the TEST_TIMEOUT_MULTIPLIER env var as f64 with default 1.0. Add scaled_timeout(u64) and scaled_duration(u64) helpers to compute adjusted timeouts and Durations. Replace hard-coded second-based timeout literals with scaled_timeout or scaled_duration in TestContext helpers and Kubernetes resource wait functions. Update trusted_execution_cluster tests to use scaled_timeout and scaled_duration for resource creation, deletion, deployment readiness, and polling logic. Update attestation tests to use scaled_timeout for VM lifecycle waits (running state, SSH readiness/unavailability) and resource deletion waits.	test_utils/src/lib.rs tests/trusted_execution_cluster.rs tests/attestation.rs
Add dedicated Make targets and documentation for running specific integration test suites with optional timeout scaling.	Add attestation-tests and trusted_execution_cluster-tests Make targets to run the corresponding integration test binaries with required environment variables and features. Document TEST_TIMEOUT_MULTIPLIER usage for slow systems in tests/README.md. Document how to run only the attestation or trusted_execution_cluster test sets via the new Make targets in tests/README.md.	Makefile tests/README.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The timeout_multiplier() helper currently allows TEST_TIMEOUT_MULTIPLIER values of 0 or negative (which can lead to zero or effectively unbounded timeouts via float→u64 casting); consider clamping to a sane positive range (e.g. >= 1.0 and some upper bound) before applying it.
• The new attestation-tests and trusted_execution_cluster-tests Makefile targets duplicate most of the integration-tests command; consider factoring out the common RUST_LOG/image/env setup into a single variable or pattern rule to reduce repetition and keep them in sync.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The `timeout_multiplier()` helper currently allows `TEST_TIMEOUT_MULTIPLIER` values of 0 or negative (which can lead to zero or effectively unbounded timeouts via float→u64 casting); consider clamping to a sane positive range (e.g. `>= 1.0` and some upper bound) before applying it.
- The new `attestation-tests` and `trusted_execution_cluster-tests` Makefile targets duplicate most of the `integration-tests` command; consider factoring out the common `RUST_LOG`/image/env setup into a single variable or pattern rule to reduce repetition and keep them in sync.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Jakob-Naucke]

commit message nit: separately, wrap lines

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jakob-Naucke, yairpod

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[uril]

Looks good to me, thanks

[openshift-ci]

New changes are detected. LGTM label has been removed.