Separately specify Trustee KBS port and public Trustee address#60
Merged
alicefr merged 2 commits intoOct 16, 2025
Merged
Conversation
Trustee port was taken from the public address to avoid redundany, but that made 2.5 assumptions that aren't necessarily true: - Trustee public address is always known ahead of time. - Public address will (a) contain a port that is (b) identical to the cluster-internal one. Instead, add the `trusteeKbsPort` field to the cocl CRD. The existing field `trusteeAddr` is renamed to `publicTrusteeAddr` for clarity. Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
was confidential-containers.io, which isn't this project Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Jakob-Naucke
changed the title
Contributor
|
Thanks Jakob! |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trustee port was taken from the public address to avoid redundany, but
that made 2.5 assumptions that aren't necessarily true:
cluster-internal one.
Instead, add the
trusteeKbsPortfield to the cocl CRD. The existingfield
trusteeAddris renamed topublicTrusteeAddrfor clarity.Drive-by: rename API group as discussed in #44