Conversation
Codecov ReportBase: 59.03% // Head: 59.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 59.03% 59.07% +0.04%
==========================================
Files 21 23 +2
Lines 1506 1774 +268
Branches 316 370 +54
==========================================
+ Hits 889 1048 +159
- Misses 540 634 +94
- Partials 77 92 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cducrest
approved these changes
Nov 23, 2022
compojoom
force-pushed
the
update_eip1559
branch
from
bd175f8 to
4a40d5b
Compare
the end2end tests now run on ganache with EIP1559 and some of the tests needed updating. Also updated to latest ethersjs version.
I decided to skip some unwEth tests that are failing for identity and Safe wallets . We can revisit them later.
compojoom
force-pushed
the
update_eip1559
branch
from
4a40d5b to
17f49b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the end2end tests now run on ganache with EIP1559 and some of the tests needed updating.
Also updated to latest ethersjs version.