🐛 fix(ci): escape ${{ in composite action description#119
Merged
Conversation
ZaxShen
added a commit
that referenced
this pull request
May 20, 2026
…#118 + #119) Two tightly-coupled fixes from 2026-04-29 L0-L5 verification: - #118: scripts/hooks/write-active-workspace-sentinel.sh was committed at mode 100644 (sibling hooks are 100755). Production regression from #113. Chmod fix. - #119: L0 install-smoke executable-check used (echo FAIL && exit 1) in a subshell, so build kept going past the FAIL. Replace with set -e + brace-group { ...; exit 1; } so exit propagates. Without #119, #118 would have shipped silently (the build didn't fail when the bug existed). Pairing them keeps the verification chain honest going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for #118.
Bug
PR #118's composite action loaded with:
```
##[error]/home/runner/work/plugin/plugin/./.github/actions/verify-cc-auth/action.yml (Line: 2, Col: 14): Unrecognized named-value: 'secrets'.
```
The `description:` field literally contained `token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}` as a usage example. GitHub Actions evaluates expressions even inside the description field — and composite actions don't have access to the `secrets` context (only `inputs`), so the action loader exploded.
Fix
Strip the `${{ secrets... }}` example out of the description field. Keep description as plain prose.
(Could also have escaped via `$${{...}}` but removing the example is cleaner — anyone reading the action source sees the inputs schema directly.)
Verify
After merge, re-trigger `gh workflow run l6-dogfood.yml --ref dev`. The composite should load and run the auth check.
🤖 Generated with Claude Code