fix(workflow): settle fire limits atomically

[trvon]

Summary

• enforce workflow-wide and state-local fire limits under the Store lock
• preserve terminal settlement and evidenced exits without permitting renewal
• account for ordinary and cadence activation budgets
• add deterministic and property-based limit coverage

Validation

• full branch suite: 919 tests passed

Stack

3 of 6. Base: fix/execution-identity-authority.

[Copilot]

🟡 Changes recommended

A new unconditional structuredClone in LoopStore.fireUnlocked introduces avoidable per-fire overhead on a hot path and should be made conditional/removed.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR tightens workflow fire-limit enforcement by settling both workflow-wide and state-local cadence limits atomically inside LoopStore’s lock, aiming to prevent races and preserve correct terminal settlement behavior in pi-loop’s workflow controller runtime.

Changes:

• Updates default workflow fire budgeting to account for both ordinary (non-cadenced) activations and cadence-driven fires.
• Settles fire-limit exhaustion during LoopStore fire handling under the store lock (including pause/delete settlement paths).
• Adds deterministic integration, regression, and property-based tests to cover workflow/state fire caps and atomic settlement invariants.

File summaries

File	Description
test/workflow-task-integration.test.ts	Adds an integration regression ensuring default workflow budgets allow a normal phase + one cadence fire + terminal completion.
test/property/store.property.test.ts	Adds a property test asserting persisted fireCount/state fire counts never exceed the active cap and that exhaustion pauses.
test/astra-workflow-limits.test.ts	Adds targeted regressions for atomic rejection/no-write behavior after exhaustion across reopened stores.
src/tools/workflow-tools.ts	Refines workflowDefaultMaxFires to reserve capacity for ordinary activations and cadence budgets.
src/store.ts	Settles workflow/state fire limits under lock during fire, pausing/deleting immediately on exhaustion and preserving returned fire results.

Review details

• Files reviewed: 5/5 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.