-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Add content_index to Citation and THINKING_CONTENT to CitationType enum #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe OpenAPI specification for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/Cohere/openapi.yaml (1)
13177-13179: Clarify constraints for the newcontent_indexfieldGood addition. To avoid ambiguity and enable stronger validation downstream, consider specifying explicit constraints:
- Add
minimum: 0(orexclusiveMinimum: -1) so negative indices are rejected.- Add
format: int32to be consistent with other integer fields if you already use it elsewhere.- If
content_indexis required for all citations, remember to list it in therequired:array for theCitationschema; otherwise clients may treat it as optional and ignore it.content_index: type: integer + format: int32 + minimum: 0 description: Index of the content block in which this citation appears.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
src/libs/Cohere/Generated/Cohere.Models.Citation.g.csis excluded by!**/generated/**src/libs/Cohere/Generated/Cohere.Models.CitationType.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Cohere/openapi.yaml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test / Build, test and publish
🔇 Additional comments (1)
src/libs/Cohere/openapi.yaml (1)
13241-13243: Ensure enum documentation & consumers coverTHINKING_CONTENT
THINKING_CONTENTslots in cleanly, but two follow-ups are easy to miss:
- Extend the description string (Line 13245) so published docs mention the new value—otherwise generators may omit it.
- Verify every switch / if-else on
CitationTypein SDKs & services now handlesTHINKING_CONTENT; otherwise they will raise “unsupported type” errors at runtime.No spec change needed here—just double-check docs and code paths.
Summary by CodeRabbit