feat(devices): count imported devices in the compliance chart#3384
Merged
Conversation
The Device Compliance donut previously excluded integration-imported devices entirely, so its total contradicted the device table right below it. Now every device counts: imported devices use the SOURCE's verdict (sourceCompliance.isCompliant) for Compliant/Non-Compliant, and imported devices with no verdict land in a gray 'Not Tracked' segment instead of being fabricated into a verdict. The Not Tracked legend entry only appears when it exists, so agent/Fleet-only orgs see no change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TfDHFTwRgYxUoyyqGkHPDc
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…lack CHART_COLORS referenced hsl(var(--chart-positive)) etc. from the legacy @trycompai/ui stylesheet, which the app no longer loads — so all pie segments fell back to SVG-default black. Use the design-system tokens the app actually defines: --primary (brand green) for compliant, --destructive for non-compliant, --muted-foreground for not tracked. Dark mode adapts automatically. Note: vendors/backup-overview charts reference the same dead tokens (same black rendering) — left for a follow-up, out of scope here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TfDHFTwRgYxUoyyqGkHPDc
claudfuen
pushed a commit
that referenced
this pull request
Jul 10, 2026
# [3.100.0](v3.99.3...v3.100.0) (2026-07-10) ### Bug Fixes * **devices:** address cubic review on device-sync connection status ([4fa7598](4fa7598)) * **devices:** address release-PR review on device sync ([#3387](#3387)) ([f0c9f2c](f0c9f2c)) * **devices:** show reconnect hint when device-sync connection is errored ([d41bb5c](d41bb5c)) * **devices:** surface broken saved sync source on the closed trigger ([d59f0a0](d59f0a0)) ### Features * **devices:** count imported devices in the compliance chart ([#3384](#3384)) ([f94f02a](f94f02a)) * **devices:** universal source-reported compliance + last-seen for device sync ([#3383](#3383)) ([c45fa5f](c45fa5f))
Contributor
|
🎉 This PR is included in version 3.100.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Device Compliance donut excluded integration-imported devices entirely — with an Intune-synced device in the table, the chart said "3 devices" while the table showed 4, and the Compliant counts didn't line up with the visible Yes badges. Reads as a bug (and was reported as one).
Change
Every device in the table now counts in the chart:
sourceCompliance.isCompliant) → Compliant / Non-CompliantTests
5 new chart cases (verdict compliant/non-compliant, no-verdict → Not Tracked, imported-only org, no spurious legend entry) — 88/88 devices tests passing, typecheck clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TfDHFTwRgYxUoyyqGkHPDc
Summary by cubic
Include integration-imported devices in the Device Compliance chart so totals match the table, and fix chart colors to use design‑system tokens. Imported devices without a source verdict now show as a gray Not Tracked segment.
sourceCompliance.isCompliantfor Compliant/Non-Compliant; no verdict → Not Tracked.Written for commit bb9102d. Summary will update on new commits.