Skip to content

fix(app): let users start a new automation instead of being trapped in a half-finished connect - #3525

Merged
tofikwest merged 1 commit into
mainfrom
feat/browser-connect-resume-nonblocking
Jul 28, 2026
Merged

fix(app): let users start a new automation instead of being trapped in a half-finished connect#3525
tofikwest merged 1 commit into
mainfrom
feat/browser-connect-resume-nonblocking

Conversation

@tofikwest

@tofikwest tofikwest commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Problem

If you started connecting a vendor and left, returning to the task auto-reopened that sign-in full-screen — the whole Browser Automations panel became the connect flow, with only Finish or Cancel (×). There was no way to create a new (or different) automation without cancelling out. The connect resume was a forced modal, unlike automation drafts, which are surfaced as a resumable strip and never block anything.

Fix

Make the half-finished connect behave like a draft: surface it as a resumable band instead of hijacking the panel.

  • On task open, you land on your automations (list / Create / Connect-another) — not the forced sign-in.
  • The unfinished connect shows as a "Finish connecting to {vendor}" strip with Resume and Discard (mirrors the existing DraftsStrip).
  • You decide: Resume to finish it, Discard to drop it, or ignore it and Create / Connect a new one.
  • Starting a fresh connect clears any half-finished one, so the flow never resumes into a stale draft.

Same resumable steps as before (the connect flow still resumes at analysis / method-choice — a live sign-in session never survived a reload anyway). Only the forced full-screen takeover is removed.

Scope

  • BrowserAutomations.tsx — replace the auto-reopen effect with a resumable-strip state; clear it wherever connect state is cleared; render the strip on the empty states + list; empty-state "Connect" now starts fresh.
  • New ResumeConnectStrip + test.

Tests

96 browser-automations tests green (incl. the new strip test); app typecheck clean; no legacy UI/lucide imports.


Summary by cubic

Let users return to their automations and choose to resume, discard, or start a new vendor connect instead of being forced into the full-screen connect flow. This removes the blocking experience and makes unfinished connects behave like drafts.

  • Bug Fixes
    • Unfinished connects show as a “Finish connecting to {vendor}” strip with Resume and Discard; no full-screen takeover.
    • Starting a new connect always clears saved connect state; empty-state “Connect” starts fresh.
    • Resume reopens the flow using the saved state; Discard removes it.
    • Added ResumeConnectStrip and tests.

Written for commit 57c1d40. Summary will update on new commits.

Review in cubic

…creen step

Returning to a task with an unfinished vendor connect used to auto-reopen that
sign-in full-screen, trapping the user in it — there was no way to create a new
(or different) automation without cancelling out.

Now the in-progress connect is surfaced as a resumable band (mirroring the
existing drafts strip): the user lands on their automations and chooses — Resume
to finish it, Discard to drop it, or just Create/Connect a new one. Starting a
fresh connect clears any half-finished one so the flow never resumes into a stale
draft. Same resumable steps as before (analysis / method choice); only the
forced takeover is gone.

Adds ResumeConnectStrip + a test.
@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jul 28, 2026 7:53pm
comp-framework-editor Ready Ready Preview, Comment Jul 28, 2026 7:53pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped Jul 28, 2026 7:53pm

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@tofikwest
tofikwest merged commit b1afcae into main Jul 28, 2026
10 checks passed
@tofikwest
tofikwest deleted the feat/browser-connect-resume-nonblocking branch July 28, 2026 20:33
claudfuen pushed a commit that referenced this pull request Jul 29, 2026
# [3.111.0](v3.110.1...v3.111.0) (2026-07-29)

### Bug Fixes

* **api:** classify the take-over method on an unclear outcome too ([539fdba](539fdba))
* **api:** only classify a switchable passkey when a code method exists ([#3528](#3528)) ([0d79093](0d79093))
* **app:** make a half-finished connect resumable, not a forced full-screen step ([#3525](#3525)) ([b1afcae](b1afcae))
* **cloud-security:** add missing logGroupName to CreateLogGroup remediation ([#3515](#3515)) ([76ae56c](76ae56c))
* harden sign-in classification + align take-over messaging ([#3527](#3527)) ([914cb1e](914cb1e))
* **integrations:** wrap aws add account form in dialog and scroll into view ([#3526](#3526)) ([07e91ae](07e91ae)), closes [#418](#418)
* make the 2FA take-over universal — tailor guidance to what the page asks for ([#3520](#3520)) ([b12f3fe](b12f3fe))
* **policies:** remove archived policies from framework controls after unlinking ([#3513](#3513)) ([d639df2](d639df2))
* **training:** defer completion email and share canonical training IDs ([#3529](#3529)) ([fecb556](fecb556))
* **training:** remove rbac gate from mark-complete endpoint ([#3501](#3501)) ([8c5e98f](8c5e98f)), closes [#3455](#3455)

### Features

* connection longevity + one-click 'Make permanent' 2FA ([#3524](#3524)) ([7345e3c](7345e3c))
* **policies:** add bulk upload for policy migration ([#3514](#3514)) ([1940f06](1940f06))
* **security-questionnaire:** add browser extension ([#3064](#3064)) ([e678421](e678421))
@claudfuen

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.111.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants